Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 10829091: Set ANDROID_SDK_ROOT to point to checked in sdk. (Closed)

Created:
8 years, 4 months ago by navabi
Modified:
8 years, 4 months ago
Reviewers:
cmp, shashi, Yaron, Isaac (away)
CC:
chromium-reviews
Visibility:
Public.

Description

Set ANDROID_SDK_ROOT to point to checked in sdk. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M build/android/envsetup_functions.sh View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
navabi
8 years, 4 months ago (2012-07-30 23:50:37 UTC) #1
cmp
lgtm, but makes sense to wait for one or two others on the reviewers list ...
8 years, 4 months ago (2012-07-30 23:52:09 UTC) #2
cmp
(btw, typo in title+description: ANDRIOD -> ANDROID)
8 years, 4 months ago (2012-07-30 23:52:34 UTC) #3
Isaac (away)
lgtm, I edited description to fix typo
8 years, 4 months ago (2012-07-30 23:54:00 UTC) #4
Yaron
cc'ing torne as long-term this should probably move into gyp (he's working to kill envsetup). ...
8 years, 4 months ago (2012-07-30 23:55:46 UTC) #5
cmp
Isaac, FYI it is possible that CLs landed directly would not use your edits, they ...
8 years, 4 months ago (2012-07-30 23:57:57 UTC) #6
Torne
On 2012/07/30 23:55:46, Yaron wrote: > cc'ing torne as long-term this should probably move into ...
8 years, 4 months ago (2012-07-31 09:44:41 UTC) #7
navabi
Yaron, you are right. I removed the ANDROID_SDK_ROOT export form the build bot script in ...
8 years, 4 months ago (2012-07-31 18:34:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/10829091/1
8 years, 4 months ago (2012-07-31 18:35:00 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 20:03:43 UTC) #10
Change committed as 149258

Powered by Google App Engine
This is Rietveld 408576698