Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 10829089: Remove repeated target definition from net.gyp (Closed)

Created:
8 years, 4 months ago by csharp
Modified:
8 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, M-A Ruel
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove repeated target definition from net.gyp TBR=wtc BUG= TEST=Swarm bots stop failing the runhooks step Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149093

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M net/net.gyp View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
csharp
Hey Chase, are you a good person to send my swarm/build bot cls to while ...
8 years, 4 months ago (2012-07-30 21:46:52 UTC) #1
cmp
lgtm Sure, I'm happy to take a look while M-A is gone or in general ...
8 years, 4 months ago (2012-07-30 23:00:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10829089/1
8 years, 4 months ago (2012-07-30 23:01:51 UTC) #3
commit-bot: I haz the power
Presubmit check for 10829089-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-30 23:01:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10829089/1
8 years, 4 months ago (2012-07-30 23:05:01 UTC) #5
commit-bot: I haz the power
Change committed as 149093
8 years, 4 months ago (2012-07-31 00:44:19 UTC) #6
wtc
LGTM. noyau is a better reviewer for this change, but I believe he thinks this ...
8 years, 4 months ago (2012-08-01 17:42:10 UTC) #7
noyau (Ping after 24h)
8 years, 4 months ago (2012-08-02 08:52:32 UTC) #8
On 2012/08/01 17:42:10, wtc wrote:
> LGTM.
> 
> noyau is a better reviewer for this change, but I believe
> he thinks this change is correct.

Yes, I'm the one who mistakenly created the duplicate. Sorry about that. LGTM.

Powered by Google App Engine
This is Rietveld 408576698