Issue 10829086: Reland 148792

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829086: Reland 148792 (Closed)

Created:
8 years, 4 months ago by Nicolas Zea

Modified:
8 years, 4 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reland 148792 Relanding after rebasing. [Sync] Remove CleanupDisabledTypes command and move purge logic into SyncManager." Original codereview at http://codereview.chromium.org/10541079/ BUG=131433, 90868 TBR=tim@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149052

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+185 lines, -331 lines)			Patch
D	sync/engine/cleanup_disabled_types_command.h	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	sync/engine/cleanup_disabled_types_command.cc	View	1 chunk	+0 lines, -67 lines	0 comments	Download
D	sync/engine/cleanup_disabled_types_command_unittest.cc	View	1 chunk	+0 lines, -75 lines	0 comments	Download
M	sync/engine/sync_scheduler_impl.h	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	sync/engine/sync_scheduler_impl.cc	View	8 chunks	+0 lines, -43 lines	0 comments	Download
M	sync/engine/sync_scheduler_unittest.cc	View	8 chunks	+5 lines, -61 lines	0 comments	Download
M	sync/engine/syncer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sync/engine/syncer.cc	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	sync/internal_api/sync_manager_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/internal_api/sync_manager_impl.cc	View	2 chunks	+26 lines, -0 lines	0 comments	Download
M	sync/internal_api/syncapi_unittest.cc	View	6 chunks	+152 lines, -8 lines	0 comments	Download
M	sync/sessions/sync_session_context.h	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	sync/sync.gyp	View	2 chunks	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/10829086/1

8 years, 4 months ago (2012-07-30 20:29:55 UTC) #1

Change committed as 149052