Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 10829084: Make Sync Messages with lots of parameters and no return work (Closed)

Created:
8 years, 4 months ago by Fady Samuel
Modified:
8 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Make Sync Messages with lots of parameters and no return work There are a couple of broken macros that will be used by the browser plugin. BUG=none TEST=compiles (+ local testing with browser plugin) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ipc/ipc_message_macros.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Fady Samuel
8 years, 4 months ago (2012-07-30 20:00:32 UTC) #1
jam
lgtm
8 years, 4 months ago (2012-07-30 20:20:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10829084/1
8 years, 4 months ago (2012-07-30 20:25:18 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 20:25:20 UTC) #4
Presubmit check for 10829084-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ipc/ipc_message_macros.h, line 396, 95 chars \
  ipc/ipc_message_macros.h, line 411, 105 chars

Powered by Google App Engine
This is Rietveld 408576698