Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1800)

Unified Diff: content/common/gpu/client/gpu_video_decode_accelerator_host.cc

Issue 10829082: Don't try to read message->type() after message has been deleted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/client/gpu_video_decode_accelerator_host.cc
diff --git a/content/common/gpu/client/gpu_video_decode_accelerator_host.cc b/content/common/gpu/client/gpu_video_decode_accelerator_host.cc
index 078171f6f752ca56f6762dedea91ae6a652736c4..de43eef617f4693ee44e0da9a938aa1aea0a9e7c 100644
--- a/content/common/gpu/client/gpu_video_decode_accelerator_host.cc
+++ b/content/common/gpu/client/gpu_video_decode_accelerator_host.cc
@@ -132,12 +132,13 @@ void GpuVideoDecodeAcceleratorHost::Send(IPC::Message* message) {
// messages to the gpu channel through this object. But queued posted tasks
// can still be draining, so we're forgiving and simply ignore them.
bool error = false;
+ uint32 message_type = message->type();
if (!channel_) {
delete message;
- DLOG(ERROR) << "Send(" << message->type() << ") after error ignored";
+ DLOG(ERROR) << "Send(" << message_type << ") after error ignored";
error = true;
} else if (!channel_->Send(message)) {
- DLOG(ERROR) << "Send(" << message->type() << ") failed";
+ DLOG(ERROR) << "Send(" << message_type << ") failed";
error = true;
}
if (error)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698