Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 10829074: Browser Plugin: Rename BrowserPluginMsg/BrowserPluginHostMsg to OldBrowserPluginMsg/OldBrowserPlugi… (Closed)

Created:
8 years, 4 months ago by Fady Samuel
Modified:
8 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rjkroege
Visibility:
Public.

Description

Browser Plugin: Rename BrowserPluginMsg/BrowserPluginHostMsg to OldBrowserPluginMsg/OldBrowserPluginHostMsg The upcoming rewrite of the browser plugin has colliding names for IPC messages. Rename existing messages to Old in preparation for the new implementation. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149116

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -124 lines) Patch
M content/browser/browser_plugin/old/browser_plugin_host.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/browser_plugin/old/browser_plugin_host_helper.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D content/common/browser_plugin_messages.h View 1 chunk +0 lines, -92 lines 0 comments Download
M content/common/content_message_generator.h View 1 2 chunks +1 line, -1 line 0 comments Download
A + content/common/old_browser_plugin_messages.h View 5 chunks +9 lines, -9 lines 0 comments Download
M content/content_common.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/old/browser_plugin.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/browser_plugin/old/browser_plugin_channel_manager.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/browser_plugin/old/guest_to_embedder_channel.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Fady Samuel
8 years, 4 months ago (2012-07-30 02:52:50 UTC) #1
Fady Samuel
8 years, 4 months ago (2012-07-30 02:52:50 UTC) #2
jam
lgtm http://codereview.chromium.org/10829074/diff/1/content/common/content_message_generator.h File content/common/content_message_generator.h (right): http://codereview.chromium.org/10829074/diff/1/content/common/content_message_generator.h#newcode11 content/common/content_message_generator.h:11: #include "content/common/old_browser_plugin_messages.h" nit: sort http://codereview.chromium.org/10829074/diff/1/content/content_common.gypi File content/content_common.gypi (right): ...
8 years, 4 months ago (2012-07-30 15:27:44 UTC) #3
Fady Samuel
Fixed nits. Committing now. https://chromiumcodereview.appspot.com/10829074/diff/1/content/common/content_message_generator.h File content/common/content_message_generator.h (right): https://chromiumcodereview.appspot.com/10829074/diff/1/content/common/content_message_generator.h#newcode11 content/common/content_message_generator.h:11: #include "content/common/old_browser_plugin_messages.h" On 2012/07/30 15:27:44, ...
8 years, 4 months ago (2012-07-30 22:11:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10829074/6002
8 years, 4 months ago (2012-07-30 22:12:09 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 02:10:58 UTC) #6
Change committed as 149116

Powered by Google App Engine
This is Rietveld 408576698