Issue 10829070: Move resource_dispatcher_host_browsertest.cc to content_browsertests.

Issue 10829070: Move resource_dispatcher_host_browsertest.cc to content_browsertests. (Closed)

Created:
8 years, 4 months ago by jam

Modified:
8 years, 4 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move resource_dispatcher_host_browsertest.cc to content_browsertests. BUG=90448 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148966

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : sync #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -420 lines)			Patch
chrome/browser_tests.isolate	View	1 2 3	4 chunks	+0 lines, -27 lines	0 comments	Download
chrome/chrome_tests.gypi	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
chrome/test/data/content-disposition-empty.html	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
chrome/test/data/content-disposition-empty.html.mock-http-headers	View	1 2 3	1 chunk	+0 lines, -6 lines	0 comments	Download
chrome/test/data/content-disposition-inline.html	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
chrome/test/data/content-disposition-inline.html.mock-http-headers	View	1 2 3	1 chunk	+0 lines, -6 lines	0 comments	Download
chrome/test/data/content-sniffer-test0.html	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
chrome/test/data/content-sniffer-test0.html.mock-http-headers	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
chrome/test/data/content-sniffer-test1.html	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
chrome/test/data/content-sniffer-test1.html.mock-http-headers	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
chrome/test/data/content-sniffer-test2.html	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
chrome/test/data/content-sniffer-test2.html.mock-http-headers	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
chrome/test/data/content-sniffer-test3.html	View	1 2 3	1 chunk	+0 lines, -16 lines	0 comments	Download
chrome/test/data/content-sniffer-test3-frame.txt.mock-http-headers	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
chrome/test/data/content-sniffer-test3.html.mock-http-headers	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
chrome/test/data/cross-origin-redirect-blocked.html	View	1 2 3	1 chunk	+0 lines, -56 lines	0 comments	Download
chrome/test/data/dynamic1.html	View	1 2 3	1 chunk	+0 lines, -27 lines	0 comments	Download
chrome/test/data/dynamic2.html	View	1 2 3	1 chunk	+0 lines, -31 lines	0 comments	Download
chrome/test/data/nosniff-test.html	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
chrome/test/data/nosniff-test.html.mock-http-headers	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
chrome/test/data/onunload_cookie.html	View	1 2 3	1 chunk	+0 lines, -18 lines	0 comments	Download
chrome/test/data/sync_xmlhttprequest.html	View	1 2 3	1 chunk	+0 lines, -32 lines	0 comments	Download
chrome/test/data/sync_xmlhttprequest_disallowed.html	View	1 2 3	1 chunk	+0 lines, -29 lines	0 comments	Download
chrome/test/data/sync_xmlhttprequest_during_unload.html	View	1 2 3	1 chunk	+0 lines, -20 lines	0 comments	Download
chrome/test/perf/shutdown_test.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
content/browser/renderer_host/resource_dispatcher_host_browsertest.cc	View	1 2 3	19 chunks	+82 lines, -110 lines	0 comments	Download
content/content_tests.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
content/shell/shell_download_manager_delegate.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
content/shell/shell_download_manager_delegate.cc	View	1 2 3	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

I'll commit this after http://codereview.chromium.org/10831056/

8 years, 4 months ago (2012-07-28 04:23:14 UTC) #1

darin (slow to review)

Do those data files need to be added to content? LGTM

8 years, 4 months ago (2012-07-28 05:57:48 UTC) #2

jam

8 years, 4 months ago (2012-07-28 06:10:36 UTC) #3

On Fri, Jul 27, 2012 at 10:57 PM, <darin@chromium.org> wrote:

> Do those data files need to be added to content?
>

I added them in
http://src.chromium.org/viewvc/chrome?view=rev&revision=148884 because  the
trybot wouldn't accept the file move (see patchset 1). I've been having
this issue with most of these conversions so I usually just copy the files
first and do it through svn.

>
> LGTM
>
>
http://codereview.chromium.**org/10829070/<http://codereview.chromium.org/108...
>

Expand Messages | Collapse Messages