Add query formulation time to aqs (assisted query stats) parameter

chrome/browser/ui/omnibox/omnibox_edit_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/omnibox/omnibox_edit_model.h"
 
 #include <string>
 
+#include "base/format_macros.h"
 #include "base/metrics/histogram.h"
 #include "base/string_util.h"
+#include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/autocomplete/autocomplete_classifier.h"
 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"
 #include "chrome/browser/autocomplete/autocomplete_input.h"
 #include "chrome/browser/autocomplete/autocomplete_log.h"
 #include "chrome/browser/autocomplete/extension_app_provider.h"
 #include "chrome/browser/autocomplete/keyword_provider.h"
 #include "chrome/browser/autocomplete/search_provider.h"
 #include "chrome/browser/bookmarks/bookmark_utils.h"
@@ skipping 575 matching lines @@
   }
 
   if (disposition != NEW_BACKGROUND_TAB) {
     in_revert_ = true;
     view_->RevertAll();  // Revert the box to its unedited state
   }
 
   if (match.type == AutocompleteMatch::EXTENSION_APP) {
     ExtensionAppProvider::LaunchAppFromOmnibox(match, profile_, disposition);
   } else {
-    controller_->OnAutocompleteAccept(match.destination_url, disposition,
+    GURL destination_url(match.destination_url);
+    if (template_url && match.search_terms_args.get()) {

[Peter Kasting, 2012/07/31 02:35:01]

I think you should add "&&
!match.search_terms_args->assisted_query_stats.empty()" to this conditional
instead of doing it later; we don't actually need to do anything in here if that
check fails.

[hfung, 2012/07/31 17:14:45]

Done.

+      // Append the query formulation time (time from when the user first typed

[Peter Kasting, 2012/07/31 02:35:01]

Nit: The comment should probably go up above this conditional (i.e. at the top
of the code you're adding).

[hfung, 2012/07/31 17:14:45]

Done.

+      // a character into the omnibox to when the user selected a query) to the
+      // AQS parameter if other AQS parameters were already populated.
+      base::TimeDelta query_formulation_time =
+          base::TimeTicks::Now() - time_user_first_modified_omnibox_;
+      TemplateURLRef::SearchTermsArgs search_terms_args(
+          *match.search_terms_args);
+      if (!search_terms_args.assisted_query_stats.empty()) {
+        search_terms_args.assisted_query_stats +=
+            base::StringPrintf(".%" PRId64,
+                               query_formulation_time.InMilliseconds());
+      }
+      destination_url = GURL(template_url->url_ref().
+                             ReplaceSearchTerms(search_terms_args));
+    }
+    controller_->OnAutocompleteAccept(destination_url, disposition,
                                       match.transition, alternate_nav_url);
   }
 
   if (match.starred)
     bookmark_utils::RecordBookmarkLaunch(bookmark_utils::LAUNCH_OMNIBOX);
 
   InstantController* instant = controller_->GetInstant();
   if (instant && !popup_->IsOpen())
     instant->DestroyPreviewContents();
   in_revert_ = false;
@@ skipping 556 matching lines @@
 }
 
 void OmniboxEditModel::ClassifyStringForPasteAndGo(
     const string16& text,
     AutocompleteMatch* match,
     GURL* alternate_nav_url) const {
   DCHECK(match);
   AutocompleteClassifierFactory::GetForProfile(profile_)->Classify(text,
       string16(), false, false, match, alternate_nav_url);
 }