Fix a SPDY crash bug where a CHECK() is hit because a cancelled stream is considered active by the …

net/spdy/spdy_session.h

Index: net/spdy/spdy_session.h
diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h
index 3d95101fcedd5cb5b66ec5ee6f83b1a5739708a0..1a9b1918bce02b6b2a9823bd2abe339d62e28d13 100644
--- a/net/spdy/spdy_session.h
+++ b/net/spdy/spdy_session.h
@@ -224,6 +224,9 @@ class NET_EXPORT SpdySession : public base::RefCounted<SpdySession>,
                    SpdyStatusCodes status,
                    const std::string& description);
 
+  // Delete a stream that has been created, but not yet activated.

[willchan no longer on Chromium, 2012/07/27 21:41:42]

The difference between deleting and closing a created stream is not obvious. See
the CloseStream() and CloseCreatedStream() functions above. You should add
comments explaining the difference.

[Ryan Hamilton, 2012/07/27 21:51:35]

This was an oversight on my part.  (I can't believe that I missed
CloseCreatedStream().)  I will delete the newly added method and call that
instead.

+  void DeleteCreatedStream(SpdyStream* stream);
+
   // Check if a stream is active.
   bool IsStreamActive(SpdyStreamId stream_id) const;