Fix a SPDY crash bug where a CHECK() is hit because a cancelled stream is considered active by the …

net/spdy/spdy_session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_SESSION_H_
 #define NET_SPDY_SPDY_SESSION_H_
 
 #include <algorithm>
 #include <list>
 #include <map>
@@ skipping 206 matching lines @@
   // Close a stream that has been created but is not yet active.
   void CloseCreatedStream(SpdyStream* stream, int status);
 
   // Reset a stream by sending a RST_STREAM frame with given status code.
   // Also closes the stream.  Was not piggybacked to CloseStream since not
   // all of the calls to CloseStream necessitate sending a RST_STREAM.
   void ResetStream(SpdyStreamId stream_id,
                    SpdyStatusCodes status,
                    const std::string& description);
 
+  // Delete a stream that has been created, but not yet activated.

[willchan no longer on Chromium, 2012/07/27 21:41:42]

The difference between deleting and closing a created stream is not obvious. See
the CloseStream() and CloseCreatedStream() functions above. You should add
comments explaining the difference.

[Ryan Hamilton, 2012/07/27 21:51:35]

This was an oversight on my part.  (I can't believe that I missed
CloseCreatedStream().)  I will delete the newly added method and call that
instead.

+  void DeleteCreatedStream(SpdyStream* stream);
+
   // Check if a stream is active.
   bool IsStreamActive(SpdyStreamId stream_id) const;
 
   // The LoadState is used for informing the user of the current network
   // status, such as "resolving host", "connecting", etc.
   LoadState GetLoadState() const;
 
   // Fills SSL info in |ssl_info| and returns true when SSL is in use.
   bool GetSSLInfo(SSLInfo* ssl_info,
                   bool* was_npn_negotiated,
@@ skipping 505 matching lines @@
   base::TimeDelta hung_interval_;
 
   // This SPDY proxy is allowed to push resources from origins that are
   // different from those of their associated streams.
   HostPortPair trusted_spdy_proxy_;
 };
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_SESSION_H_