Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 10829054: Support copying a partial rectangle region from the compositing surface on Win. (Closed)

Created:
8 years, 4 months ago by mazda
Modified:
8 years, 4 months ago
Reviewers:
jam, apatrick_chromium
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Support copying a partial rectangle region from the compositing surface on Win. BUG=118571 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148889

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -44 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M ui/surface/accelerated_surface_win.h View 1 3 chunks +14 lines, -5 lines 0 comments Download
M ui/surface/accelerated_surface_win.cc View 1 2 8 chunks +37 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mazda
Hi Alastair, Could you review this change?
8 years, 4 months ago (2012-07-27 18:19:05 UTC) #1
apatrick_chromium
LGTM. You need an owner for content/browser. http://codereview.chromium.org/10829054/diff/6001/ui/surface/accelerated_surface_win.cc File ui/surface/accelerated_surface_win.cc (right): http://codereview.chromium.org/10829054/diff/6001/ui/surface/accelerated_surface_win.cc#newcode124 ui/surface/accelerated_surface_win.cc:124: int GetResampleCount(const ...
8 years, 4 months ago (2012-07-27 18:28:19 UTC) #2
mazda
Thank you for the review. +jam, could you do an OWNERS review for content/browser/renderer_host? http://codereview.chromium.org/10829054/diff/6001/ui/surface/accelerated_surface_win.cc ...
8 years, 4 months ago (2012-07-27 19:29:10 UTC) #3
jam
lgtm
8 years, 4 months ago (2012-07-27 23:48:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10829054/3003
8 years, 4 months ago (2012-07-28 00:30:22 UTC) #5
commit-bot: I haz the power
Try job failure for 10829054-3003 (retry) on win_rel for step "net_unittests". It's a second try, ...
8 years, 4 months ago (2012-07-28 02:29:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10829054/3003
8 years, 4 months ago (2012-07-28 04:05:53 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-07-28 06:40:57 UTC) #8
Change committed as 148889

Powered by Google App Engine
This is Rietveld 408576698