Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 10829048: Update WebDriver atoms to pick up r17582. (Closed)

Created:
8 years, 5 months ago by kkania
Modified:
8 years, 4 months ago
Reviewers:
dennis_jeffrey, zori
CC:
chromium-reviews, kkania
Visibility:
Public.

Description

Update WebDriver atoms to r17589 to pick up r17582. This fixes the find elements command when used on pages with prototype JS lib. BUG=chromedriver:102 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148795

Patch Set 1 #

Total comments: 8

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5739 lines, -5051 lines) Patch
A chrome/test/webdriver/test/bad_native_funcs.html View 1 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/test/webdriver/test/chromedriver_tests.py View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/webdriver/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/webdriver/atoms.cc View 32 chunks +5687 lines, -5050 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kkania
8 years, 5 months ago (2012-07-27 00:07:57 UTC) #1
dennis_jeffrey
The README file says the atoms were generated from version 17589, but the CL description ...
8 years, 5 months ago (2012-07-27 00:19:30 UTC) #2
zori
https://chromiumcodereview.appspot.com/10829048/diff/1/chrome/test/webdriver/test/chromedriver_tests.py File chrome/test/webdriver/test/chromedriver_tests.py (right): https://chromiumcodereview.appspot.com/10829048/diff/1/chrome/test/webdriver/test/chromedriver_tests.py#newcode1156 chrome/test/webdriver/test/chromedriver_tests.py:1156: driver.find_element_by_tag_name('body').find_elements_by_tag_name('div') So 'find_element_by_tag_name' would not have exposed the bug, ...
8 years, 5 months ago (2012-07-27 00:41:34 UTC) #3
kkania
Its updated to 17589, although we only care about 17582. I updated the CL description ...
8 years, 4 months ago (2012-07-27 15:48:31 UTC) #4
dennis_jeffrey
LGTM
8 years, 4 months ago (2012-07-27 16:47:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/10829048/7
8 years, 4 months ago (2012-07-27 17:50:19 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-07-27 20:43:24 UTC) #7
Change committed as 148795

Powered by Google App Engine
This is Rietveld 408576698