Deprecate unused views::Label::SetURL().

Deprecate unused views::Label::SetURL().

Reasons to deprecate:
1) This function is unused in production.
2) The directionality code was wrong:
2a: Used Unicode control character wrapping.
2b: DCHECKing URL validity precludes invalid schemes with RTL leading substrings anyway.
3) The only tangible benefit (calling ui::ElideURL) is minimal.
4) It's easy to restore (or re-impl better) if needed.

BUG=NONE
TEST=NONE

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148806

[msw, 2012-07-26 23:59:34]

Hey Peter, please take a look; thanks!
No worries if you'd like me to leave this in, though.

[Peter Kasting, 2012-07-27 01:13:01]

If it's unused, that's reason enough to kill it.

I'm skeptical on your point 2 though.  I don't know why control character
wrapping is inherently wrong, and given that GURL can mark unknown schemes as
valid, I'm not sure what you're saying with point 2b.

[Peter Kasting, 2012-07-27 01:13:17]

Forgot to write LGTM (due to my first sentence).

[msw, 2012-07-27 01:43:29]

Just to explain my thoughts and learn from you (feel free to ignore):

> I don't know why control character wrapping is inherently wrong
It does get the job done, but modifying the text contents to convey a base
direction seems hacky, obscures the operation (control characters seem
subversive compared to explicit directionality flags/settings), and make text
less amenable to modification.

> GURL can mark unknown schemes as valid
Really? Can you elaborate or point me to code?
I've been unable to find something like that, but haven't dug terribly deep.
http://code.google.com/searchframe#OAMlx_jo-ck/src/googleurl/src/gurl.h&exact...

[commit-bot: I haz the power, 2012-07-27 01:43:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10829047/1

[commit-bot: I haz the power, 2012-07-27 01:43:49]

Presubmit check for 10829047-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ui/views

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[msw, 2012-07-27 01:46:20]

+Ben for OWNERS. Please take a look; thanks!

[Peter Kasting, 2012-07-27 01:59:35]

On 2012/07/27 01:43:29, msw wrote:
> Just to explain my thoughts and learn from you (feel free to ignore):
> 
> > I don't know why control character wrapping is inherently wrong
> It does get the job done, but modifying the text contents to convey a base
> direction seems hacky, obscures the operation (control characters seem
> subversive compared to explicit directionality flags/settings), and make text
> less amenable to modification.

Well, the idea is normally that we add the control characters just before
rendering.  That may be the only way to convey directionality properly to the
font renderer in question (e.g. the Windows font renderer).

> > GURL can mark unknown schemes as valid
> Really? Can you elaborate or point me to code?
> I've been unable to find something like that, but haven't dug terribly deep.

There's a difference between unknown and invalid schemes.  The URL specs define
what a valid URL looks like.  It's possible to have a valid URL with an unknown
scheme -- for example, GURL doesn't know about magnet: or aim: URLs, to name a
couple of real ones that exist in the wild.

Invalid schemes are something else again.  I don't know the specs offhand but I
suspect they require something like "scheme characters must be ASCII".  If
that's true, then a URL with non-ASCII characters in its scheme would truly be
invalid, and in this case, it's wrong for a caller to have given it to us
claiming for it to be a URL.

In any case, this is sort of moot since, as I said, "not being used -> we should
kill it" :)

[Ben Goodger (Google), 2012-07-27 17:11:14]

lgtm

[commit-bot: I haz the power, 2012-07-27 17:55:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10829047/1

[commit-bot: I haz the power, 2012-07-27 21:10:07]

Change committed as 148806