Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: content/public/browser/navigation_entry.h

Issue 10829044: Implement NavigationControllerWebView.PostURL (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: NavigationEntry: clarify comments, return raw pointer Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_entry.h
diff --git a/content/public/browser/navigation_entry.h b/content/public/browser/navigation_entry.h
index ddbc1d0214c7d99d395c8006eb09f85088588ac0..63f0104521f70c3455b6b93bf0fe128836d710dc 100644
--- a/content/public/browser/navigation_entry.h
+++ b/content/public/browser/navigation_entry.h
@@ -7,6 +7,7 @@
#include <string>
+#include "base/memory/ref_counted_memory.h"
#include "base/string16.h"
#include "content/common/content_export.h"
#include "content/public/common/page_transition_types.h"
@@ -125,8 +126,10 @@ class NavigationEntry {
// have to be reposted to reload the page properly. This flag indicates
// whether the page had post data.
//
- // The actual post data is stored in the content_state and is extracted by
- // WebKit to actually make the request.
+ // The actual post data is stored either in
+ // 1) browser_initiated_post_data when a new post data request is started.
+ // 2) content_state when a post request has started and is extracted by
+ // WebKit to actually make the request.
virtual void SetHasPostData(bool has_post_data) = 0;
virtual bool GetHasPostData() const = 0;
@@ -134,6 +137,17 @@ class NavigationEntry {
virtual void SetPostID(int64 post_id) = 0;
virtual int64 GetPostID() const = 0;
+ // Holds the raw post data of a browser initiated post request.
+ // For efficiency, this should be cleared when content_state is populated
+ // since the data is duplicated.
+ // Note, this field:
+ // 1) is not persisted in session restore.
+ // 2) is shallow copied with the static copy Create method above.
+ // 3) may be NULL so check before use.
+ virtual void SetBrowserInitiatedPostData(
+ const base::RefCountedMemory* data) = 0;
+ virtual const base::RefCountedMemory* GetBrowserInitiatedPostData() const = 0;
boliu 2012/07/31 00:05:11 Per discussion with joth, changed to return a raw
+
// The favicon data and tracking information. See content::FaviconStatus.
virtual const FaviconStatus& GetFavicon() const = 0;
virtual FaviconStatus& GetFavicon() = 0;
« no previous file with comments | « content/public/browser/android/navigation_controller_webview.h ('k') | content/renderer/render_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698