Implement NavigationControllerWebView.PostURL

content/public/browser/navigation_entry.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_
 
 #include <string>
 
 #include "base/string16.h"
@@ skipping 105 matching lines @@
   // what it's actually called. For example, if the user types "foo.com", that
   // may redirect somewhere arbitrary like "bar.com/foo", and we want to use
   // the name that the user things of the site as having.
   //
   // This URL will be is_empty() if the URL was navigated to some other way.
   // Callers should fall back on using the regular or display URL in this case.
   virtual const GURL& GetUserTypedURL() const = 0;
 
   // Post data is form data that was posted to get to this page. The data will
   // have to be reposted to reload the page properly. This flag indicates
   // whether the page had post data.

[joth, 2012/07/26 20:41:40]

should this comment be updated as per the second paragraph of the change
description?

[boliu, 2012/07/27 22:47:41]

Done.

   //
   // The actual post data is stored in the content_state and is extracted by
   // WebKit to actually make the request.
   virtual void SetHasPostData(bool has_post_data) = 0;
   virtual bool GetHasPostData() const = 0;
 
   // The Post identifier associated with the page.
   virtual void SetPostID(int64 post_id) = 0;
   virtual int64 GetPostID() const = 0;
 
   // The favicon data and tracking information. See content::FaviconStatus.
   virtual const FaviconStatus& GetFavicon() const = 0;
   virtual FaviconStatus& GetFavicon() = 0;
 
   // All the SSL flags and state. See content::SSLStatus.
   virtual const SSLStatus& GetSSL() const = 0;
   virtual SSLStatus& GetSSL() = 0;
 
   // Store the URL that caused this NavigationEntry to be created.
   virtual void SetOriginalRequestURL(const GURL& original_url) = 0;
   virtual const GURL& GetOriginalRequestURL() const = 0;
 
   // Store whether or not we're overriding the user agent.
   virtual void SetIsOverridingUserAgent(bool override) = 0;
   virtual bool GetIsOverridingUserAgent() const = 0;
+
+  // Holds the raw post data of a browser initiated post request.
+  // It should be cleared when ContentState above is set for efficiency.
+  virtual void SetBrowserInitiatedPostData(const std::string& data) = 0;

[joth, 2012/07/26 20:41:40]

Would it make sense to have this method automatically call SetHasPostData(true)
? If so, document that here :)

Also, these two methods may as well go up on line 133 with HasPostData.

[boliu, 2012/07/27 22:47:41]

I don't think it should call SetHasPostData(true) since this is a simple data
container class and should not contain any hidden logic. For example SetPostID
does not call SetHasPostData either.

Moved to below PostID fields

[joth, 2012/07/27 23:12:38]

Makes sense.

+  virtual const std::string& GetBrowserInitiatedPostData() const = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_