Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5740)

Issue 10829042: Fix third-party license information for a number of projects (Closed)

Created:
8 years, 1 month ago by Steve Block
Modified:
8 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Fix third-party license information for a number of projects Also fix a couple of bugs in the license tool. - When scanning, ignore directories that don't contain any files, on the assumption that these are DEPS directories for projects not used by our current configuration. - Don't recurse into directories in ADDITIONAL_PATHS, just as we don't for regular third_party/foo directories. Notes - License file for third_party/mozc was taken from source header. - LICENSE.chromium_os was copied from Chromium OS source tree. This fixes 'licenses.py scan' for an Android checkout. BUG=138921 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148693

Patch Set 1 #

Patch Set 2 : Fix TODO #

Total comments: 10

Patch Set 3 : Addressed comments #

Patch Set 4 : Fix whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -23 lines) Patch
M .gitignore View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A + LICENSE.chromium_os View 1 chunk +1 line, -1 line 0 comments Download
A native_client_sdk/README.chromium View 1 chunk +5 lines, -0 lines 0 comments Download
A + third_party/mozc/LICENSE View 2 chunks +5 lines, -4 lines 0 comments Download
A third_party/mozc/README.chromium View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/licenses.py View 1 2 3 6 chunks +60 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Steve Block
This depends logically on http://codereview.chromium.org/10827044 and http://codereview.chromium.org/10827038
8 years, 1 month ago (2012-07-26 19:06:37 UTC) #1
Nico
Looks fine except for that one url. http://codereview.chromium.org/10829042/diff/9/LICENSE.chromium_os File LICENSE.chromium_os (right): http://codereview.chromium.org/10829042/diff/9/LICENSE.chromium_os#newcode1 LICENSE.chromium_os:1: // Copyright ...
8 years, 1 month ago (2012-07-26 19:45:04 UTC) #2
Steve Block
Thanks Nico http://codereview.chromium.org/10829042/diff/9/LICENSE.chromium_os File LICENSE.chromium_os (right): http://codereview.chromium.org/10829042/diff/9/LICENSE.chromium_os#newcode1 LICENSE.chromium_os:1: // Copyright (c) 2006-2009 The Chromium OS ...
8 years, 1 month ago (2012-07-26 22:11:00 UTC) #3
Nico
lgtm Thanks for working on this!
8 years, 1 month ago (2012-07-26 22:16:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/10829042/5002
8 years, 1 month ago (2012-07-26 22:45:41 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-07-27 01:52:12 UTC) #6
Change committed as 148693

Powered by Google App Engine
This is Rietveld 408576698