Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 10829038: (Views only) Resize the menu buttons on the Website Settings UI to fit the button text (Closed)

Created:
8 years, 5 months ago by markusheintz_
Modified:
8 years, 4 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

(Views only)Resize the menu buttons on the Website Settings UI to fit the button text. BUG=113688 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149173

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Total comments: 11

Patch Set 4 : Address comments (msw). #

Patch Set 5 : " #

Total comments: 6

Patch Set 6 : Address comments(msw). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M chrome/browser/ui/views/website_settings/permission_selector_view.h View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permission_selector_view.cc View 1 2 3 4 5 4 chunks +38 lines, -2 lines 0 comments Download
M ui/views/controls/button/menu_button.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M ui/views/controls/button/menu_button.cc View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
msw
While I see that the static images look nicer, I'm not sure how well this ...
8 years, 5 months ago (2012-07-26 20:01:33 UTC) #1
msw
Additionally, is there precedence for this resizing behavior? I think that typically, the dropdowns are ...
8 years, 5 months ago (2012-07-26 20:06:39 UTC) #2
markusheintz_
https://chromiumcodereview.appspot.com/10829038/diff/4001/chrome/browser/ui/views/website_settings/permission_selector_view.cc File chrome/browser/ui/views/website_settings/permission_selector_view.cc (right): https://chromiumcodereview.appspot.com/10829038/diff/4001/chrome/browser/ui/views/website_settings/permission_selector_view.cc#newcode181 chrome/browser/ui/views/website_settings/permission_selector_view.cc:181: // Scale the button to the current text size. ...
8 years, 4 months ago (2012-07-30 12:55:37 UTC) #3
markusheintz_
On 2012/07/30 12:55:37, markusheintz_ wrote: > https://chromiumcodereview.appspot.com/10829038/diff/4001/chrome/browser/ui/views/website_settings/permission_selector_view.cc > File chrome/browser/ui/views/website_settings/permission_selector_view.cc > (right): > > https://chromiumcodereview.appspot.com/10829038/diff/4001/chrome/browser/ui/views/website_settings/permission_selector_view.cc#newcode181 ...
8 years, 4 months ago (2012-07-30 12:57:58 UTC) #4
msw
LGTM with nits. https://chromiumcodereview.appspot.com/10829038/diff/4001/chrome/browser/ui/views/website_settings/permission_selector_view.cc File chrome/browser/ui/views/website_settings/permission_selector_view.cc (right): https://chromiumcodereview.appspot.com/10829038/diff/4001/chrome/browser/ui/views/website_settings/permission_selector_view.cc#newcode181 chrome/browser/ui/views/website_settings/permission_selector_view.cc:181: // Scale the button to the ...
8 years, 4 months ago (2012-07-30 15:48:42 UTC) #5
markusheintz_
Thanks a lot for the review Michael. https://chromiumcodereview.appspot.com/10829038/diff/5005/chrome/browser/ui/views/website_settings/permission_selector_view.cc File chrome/browser/ui/views/website_settings/permission_selector_view.cc (right): https://chromiumcodereview.appspot.com/10829038/diff/5005/chrome/browser/ui/views/website_settings/permission_selector_view.cc#newcode25 chrome/browser/ui/views/website_settings/permission_selector_view.cc:25: static const ...
8 years, 4 months ago (2012-07-30 16:32:05 UTC) #6
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-07-30 21:05:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10829038/12004
8 years, 4 months ago (2012-07-31 10:57:36 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 12:18:21 UTC) #9
Change committed as 149173

Powered by Google App Engine
This is Rietveld 408576698