Store secondary display layout to the user's preferences

Store secondary display layout to the user's preferences


BUG=137516
TEST=manually checked on lumpy


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148724

[oshima, 2012-07-26 15:05:18]

lgtm with one nit

http://codereview.chromium.org/10829034/diff/1/chrome/browser/chromeos/prefer...
File chrome/browser/chromeos/preferences.cc (right):

http://codereview.chromium.org/10829034/diff/1/chrome/browser/chromeos/prefer...
chrome/browser/chromeos/preferences.cc:583:
DCHECK_GE(static_cast<int>(DisplayController::LEFT), layout);
it's probably better to ignore the value if it's out of range in release build,
as the preference may contain obsolete value.

[Jun Mukai, 2012-07-26 16:29:49]

James, please also take a look at this CL as the OWNER.

http://codereview.chromium.org/10829034/diff/1/chrome/browser/chromeos/prefer...
File chrome/browser/chromeos/preferences.cc (right):

http://codereview.chromium.org/10829034/diff/1/chrome/browser/chromeos/prefer...
chrome/browser/chromeos/preferences.cc:583:
DCHECK_GE(static_cast<int>(DisplayController::LEFT), layout);
On 2012/07/26 15:05:19, oshima wrote:
> it's probably better to ignore the value if it's out of range in release
build,
> as the preference may contain obsolete value.

Done.

[James Hawkins, 2012-07-26 17:41:54]

LGTM with nit.

http://codereview.chromium.org/10829034/diff/5001/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

http://codereview.chromium.org/10829034/diff/5001/chrome/common/pref_names.cc...
chrome/common/pref_names.cc:727: // An enum that specifies the layout of the
secondary display.
nit: I'd call this an enumeration to distinguish it from the enum keyword.

[Jun Mukai, 2012-07-27 04:22:13]

http://codereview.chromium.org/10829034/diff/5001/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

http://codereview.chromium.org/10829034/diff/5001/chrome/common/pref_names.cc...
chrome/common/pref_names.cc:727: // An enum that specifies the layout of the
secondary display.
On 2012/07/26 17:41:54, James Hawkins wrote:
> nit: I'd call this an enumeration to distinguish it from the enum keyword.

Done.

[commit-bot: I haz the power, 2012-07-27 04:23:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/10829034/7002

[commit-bot: I haz the power, 2012-07-27 05:43:26]

Change committed as 148724