Issue 10829032: Remove unused chromeos::EulaScreenActor::IsTpmEnabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829032: Remove unused chromeos::EulaScreenActor::IsTpmEnabled (Closed)

Created:
8 years, 5 months ago by hashimoto

Modified:
8 years, 5 months ago

Reviewers:
Ivan Korotkov

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unused chromeos::EulaScreenActor::IsTpmEnabled BUG=126674 TEST=build success Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148723

Patch Set 1 #

Patch Set 2 : Rebase and fix copyright year #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -9 lines)			Patch
M	chrome/browser/chromeos/login/eula_screen.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/eula_screen.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/eula_screen_actor.h	View	1	2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hashimoto

On 2012/07/26 16:32:57, Ivan Korotkov wrote: > LGTM when clang passes It passed, going to ...

8 years, 5 months ago (2012-07-27 03:24:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10829032/1

8 years, 5 months ago (2012-07-27 03:24:40 UTC) #4

commit-bot: I haz the power

8 years, 5 months ago (2012-07-27 03:51:10 UTC) #5

Try job failure for 10829032-1 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Expand Messages | Collapse Messages