Add ResourceResponseHead members to IPC_STRUCT_TRAITS. Without this, missing member will not be sen…

Add ResourceResponseHead members to IPC_STRUCT_TRAITS. Without this, missing member will not be sent with ipc messages, and cause InterProcessTimeTicksConverter never work


BUG=139093
TEST= no test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150206

[James Simonsen, 2012-07-26 18:32:48]

lgtm

You'll need an OWNER to approve it too. You might need to go up a directory to
find one. It seems the ones in this directory only own specific files.

[jschuh, 2012-07-26 18:45:49]

I think the intent was to add me as a content owner, but I'm listed only for
sandbox policy. So, it will need to be someone else.

[Pan, 2012-07-27 00:48:02]

Darin,

Seems I need your approval for content/common/
Could you please review this?

Pan

[Pan, 2012-07-27 00:48:28]

On 2012/07/26 18:32:48, James Simonsen wrote:
> lgtm
> 
> You'll need an OWNER to approve it too. You might need to go up a directory to
> find one. It seems the ones in this directory only own specific files.

thanks for your help.

[Pan, 2012-07-27 00:48:58]

On 2012/07/26 18:45:49, Justin Schuh wrote:
> I think the intent was to add me as a content owner, but I'm listed only for
> sandbox policy. So, it will need to be someone else.

Got it, thanks:)

[darin (slow to review), 2012-07-27 03:00:47]

LGTM

[Pan, 2012-07-27 07:17:33]

On 2012/07/27 03:00:47, darin wrote:
> LGTM

Try robot doesn't appear,
seems I didn't get approval yet, what is the matter?

[James Simonsen, 2012-07-27 21:39:10]

On 2012/07/27 07:17:33, pan.deng wrote:
> On 2012/07/27 03:00:47, darin wrote:
> > LGTM
> 
> Try robot doesn't appear,
> seems I didn't get approval yet, what is the matter?

The try jobs are started manually. I'll take care of landing this.

[James Simonsen, 2012-07-30 22:32:58]

On 2012/07/27 21:39:10, James Simonsen wrote:
> On 2012/07/27 07:17:33, pan.deng wrote:
> > On 2012/07/27 03:00:47, darin wrote:
> > > LGTM
> > 
> > Try robot doesn't appear,
> > seems I didn't get approval yet, what is the matter?
> 
> The try jobs are started manually. I'll take care of landing this.

The try jobs failed with a bunch of check failures. Here's one:

Note: Google Test filter = FullscreenControllerInteractiveTest.EscapingMouseLock
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from FullscreenControllerInteractiveTest, where TypeParam = 
[ RUN      ] FullscreenControllerInteractiveTest.EscapingMouseLock
HTTP server started on 127.0.0.1:47663...
sending server_data: {"host": "127.0.0.1", "port": 47663} (36 bytes)
[16972:16972:0727/180059:813363664:INFO:CONSOLE(31)] "lockMouse1()", source:
http://127.0.0.1:47663/files/fullscreen_mouselock/fullscreen_mouselock.html (31)
[5:5:813368859:FATAL:inter_process_time_ticks_converter.cc(38)] Check failed:
remote_lower_bound_ <= remote_ms.value_ (813361382 vs. 0)
[0727/180143:ERROR:test_launcher.cc(379)] Test timeout (45000 ms) exceeded for
FullscreenControllerInteractiveTest.EscapingMouseLock
	base::debug::StackTrace::StackTrace() [0x69faee]
	DumpStackTraceSignalHandler() [0x4f7c0b]
	0x7f278ee4daf0
	0x7f278eef4543
	0x7f2793cb34a9
	0x7f2793cb38fc
	base::MessagePumpGlib::RunWithDispatcher() [0x6f53d0]
	MessageLoop::RunInternal() [0x6b1b28]
	base::RunLoop::Run() [0x6ccd5d]
	content::RunThisRunLoop() [0x26adc2c]
	content::WindowedNotificationObserver::Wait() [0x26add4d]
	ui_test_utils::SendKeyPressAndWait() [0x4fbe47]
	FullscreenControllerInteractiveTest_EscapingMouseLock_Test::RunTestOnMainThread()
[0x46ac2f]
	InProcessBrowserTest::RunTestOnMainThreadLoop() [0x4f83e9]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl() [0x1fa4077]
	ChromeBrowserMainParts::PreMainMessageLoopRun() [0x1fa4b3e]
	content::BrowserMainLoop::CreateThreads() [0x7e45cc]
	(anonymous namespace)::BrowserMainRunnerImpl::Initialize() [0x7e5297]
	BrowserMain() [0x2e9bd07]
	BrowserTestBase::SetUp() [0x26a78b7]
	InProcessBrowserTest::SetUp() [0x4f8c92]
	testing::Test::Run() [0x68add2]
	testing::TestInfo::Run() [0x68af2a]
	testing::TestCase::Run() [0x68b077]
	testing::internal::UnitTestImpl::RunAllTests() [0x68e06d]
	testing::UnitTest::Run() [0x688493]
	base::TestSuite::Run() [0x2695818]
	ChromeTestLauncherDelegate::RunTestSuite() [0x4eafde]
	test_launcher::LaunchTests() [0x26acfc0]
	main [0x4eb049]
	0x7f278ee38c4d
	0x43b619

It seems to affect the UI tests and browser tests. Note this causes the test to
timeout and that's where the stack trace is from, the stack trace is not where
the check failure happens. I can help take a look later today or tomorrow.

[James Simonsen, 2012-08-01 01:27:02]

I'm fixing this problem in another CL:

https://chromiumcodereview.appspot.com/10831104/

Once that goes in, we can land this one.

[Pan, 2012-08-01 06:39:41]

On 2012/08/01 01:27:02, James Simonsen wrote:
> I'm fixing this problem in another CL:
> 
> https://chromiumcodereview.appspot.com/10831104/
> 
> Once that goes in, we can land this one.

that's great, thanks for help :)

[Pan, 2012-08-07 00:21:23]

On 2012/08/01 06:39:41, pan.deng wrote:
> On 2012/08/01 01:27:02, James Simonsen wrote:
> > I'm fixing this problem in another CL:
> > 
> > https://chromiumcodereview.appspot.com/10831104/
> > 
> > Once that goes in, we can land this one.
> 
> that's great, thanks for help :)

Hey, this one hasn't been automatically committed yet.

[James Simonsen, 2012-08-07 00:31:17]

On 2012/08/07 00:21:23, pan.deng wrote:
> On 2012/08/01 06:39:41, pan.deng wrote:
> > On 2012/08/01 01:27:02, James Simonsen wrote:
> > > I'm fixing this problem in another CL:
> > > 
> > > https://chromiumcodereview.appspot.com/10831104/
> > > 
> > > Once that goes in, we can land this one.
> > 
> > that's great, thanks for help :)
> 
> Hey, this one hasn't been automatically committed yet.

Oh, hmm... I clicked commit on Friday, but nothing happened. I guess I'll have
to land it manually.