Issue 10829029: sync: don't display one-click if setup is in progress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829029: sync: don't display one-click if setup is in progress (Closed)

Created:
8 years, 5 months ago by tim (not reviewing)

Modified:
8 years, 4 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

sync: don't display one-click if setup is in progress Also makes ProfileSyncService::SetSetupInProgress(false) do nothing if the value was already false. BUG=138343 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148736

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -4 lines)			Patch
M	chrome/browser/sync/profile_sync_service.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.h	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.cc	View		2 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper_unittest.cc	View	1 2	4 chunks	+54 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

tim (not reviewing)

Hey Roger, please take a look. Patch set 1 used GMock for the tests, but ...

8 years, 5 months ago (2012-07-26 19:22:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/10829029/2001

8 years, 5 months ago (2012-07-26 20:01:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/10829029/12001

8 years, 5 months ago (2012-07-26 23:53:42 UTC) #4

Change committed as 148736