Add DCHECK(), remove if statement to prevent NULL pointer dereference.

Add DCHECK(), remove if statement to prevent NULL pointer dereference.

BUG=
TEST=
CID=102400
TBR=jamesr

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148462

[Tyler Breisacher (Chromium), 2012-07-25 23:46:18]

lgtm with optional nit

https://chromiumcodereview.appspot.com/10829028/diff/1/content/renderer/rende...
File content/renderer/render_view_impl.cc (right):

https://chromiumcodereview.appspot.com/10829028/diff/1/content/renderer/rende...
content/renderer/render_view_impl.cc:3305: DCHECK(document_state);
I think we could probably just leave out this DCHECK actually. Unless
FromDataSource is a function whose return value is checked almost all the time,
Coverity will not complain I think.

[Kyle Horimoto, 2012-07-25 23:55:12]

On 2012/07/25 23:46:18, Tyler Breisacher wrote:
> lgtm with optional nit
> 
>
https://chromiumcodereview.appspot.com/10829028/diff/1/content/renderer/rende...
> File content/renderer/render_view_impl.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10829028/diff/1/content/renderer/rende...
> content/renderer/render_view_impl.cc:3305: DCHECK(document_state);
> I think we could probably just leave out this DCHECK actually. Unless
> FromDataSource is a function whose return value is checked almost all the
time,
> Coverity will not complain I think.

Pretty sure Coverity will still complain about this. If I leave it out, the code
will be pretty similar to how it is now. Leaving it in.

[commit-bot: I haz the power, 2012-07-25 23:55:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10829028/1

[commit-bot: I haz the power, 2012-07-25 23:55:33]

Presubmit check for 10829028-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/renderer

[commit-bot: I haz the power, 2012-07-25 23:57:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10829028/1

[commit-bot: I haz the power, 2012-07-26 01:15:31]

Change committed as 148462