Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: ipc/ipc_message_utils.cc

Issue 10829024: Fixed several CHECKED_RETURN defects in ipc message utils cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message_utils.cc
diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc
index 66a68775ce1124a91a34d33bee671f6173c16f69..29159d04115bfe8c178dad7bf8aac0b3b9362634 100644
--- a/ipc/ipc_message_utils.cc
+++ b/ipc/ipc_message_utils.cc
@@ -51,6 +51,7 @@ bool ReadValue(const Message* m, PickleIterator* iter, Value** value,
int recursion);
void WriteValue(Message* m, const Value* value, int recursion) {
+ bool result;
if (recursion > kMaxRecursionDepth) {
LOG(WARNING) << "Max recursion depth hit in WriteValue.";
return;
@@ -63,25 +64,29 @@ void WriteValue(Message* m, const Value* value, int recursion) {
break;
case Value::TYPE_BOOLEAN: {
bool val;
- value->GetAsBoolean(&val);
+ result = value->GetAsBoolean(&val);
+ DCHECK(result);
WriteParam(m, val);
break;
}
case Value::TYPE_INTEGER: {
int val;
- value->GetAsInteger(&val);
+ result = value->GetAsInteger(&val);
+ DCHECK(result);
WriteParam(m, val);
break;
}
case Value::TYPE_DOUBLE: {
double val;
- value->GetAsDouble(&val);
+ result = value->GetAsDouble(&val);
+ DCHECK(result);
WriteParam(m, val);
break;
}
case Value::TYPE_STRING: {
std::string val;
- value->GetAsString(&val);
+ result = value->GetAsString(&val);
+ DCHECK(result);
WriteParam(m, val);
break;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698