Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6287)

Unified Diff: chrome/browser/rlz/rlz_extension_apitest.cc

Issue 10829017: Disable ExtensionApiTest.Rlz which has become too flaky (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/rlz/rlz_extension_apitest.cc
diff --git a/chrome/browser/rlz/rlz_extension_apitest.cc b/chrome/browser/rlz/rlz_extension_apitest.cc
index 1679d90d14772f855971baf94a848c9326649d9f..87705225441f454fbf781af11e1c8eff23101ae6 100644
--- a/chrome/browser/rlz/rlz_extension_apitest.cc
+++ b/chrome/browser/rlz/rlz_extension_apitest.cc
@@ -46,7 +46,14 @@ ExtensionFunction* MockRlzSendFinancialPingFunctionFactory() {
return new MockRlzSendFinancialPingFunction();
}
-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Rlz) {
+// Mac is flaky - http://crbug.com/137834.
+#if defined(OS_MACOSX)
+#define MAYBE_Rlz DISABLED_Rlz
+#else
+#define MAYBE_Rlz Rlz
+#endif
+
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Rlz) {
// The default test resolver doesn't allow lookups to *.google.com. That
// makes sense, but it does make RLZ's SendFinancialPing() fail -- so allow
// connections to google.com in this test.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698