Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 10828425: Add support for config changes during playback to FFmpegVideoDecoder. (Closed)

Created:
8 years, 4 months ago by acolwell GONE FROM CHROMIUM
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Add support for config changes during playback to FFmpegVideoDecoder. Also fixed a minor config change related bug in SourceBufferStream. BUG=122913 TEST=PipelineIntegrationTest.MediaSource_MP4ConfigChange, SourceBufferStreamTest.ConfigChange_Basic, PipelineIntegrationTest.MediaSource_Seek Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152666

Patch Set 1 #

Patch Set 2 : Add config_change_pending_ initializers to constructors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -105 lines) Patch
M media/filters/chunk_demuxer_unittest.cc View 4 chunks +0 lines, -14 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 3 chunks +49 lines, -36 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 10 chunks +91 lines, -22 lines 0 comments Download
M media/filters/source_buffer_stream.h View 1 chunk +7 lines, -1 line 0 comments Download
M media/filters/source_buffer_stream.cc View 1 8 chunks +27 lines, -18 lines 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 4 chunks +102 lines, -1 line 0 comments Download
M media/mp4/mp4_stream_parser.cc View 1 chunk +1 line, -8 lines 0 comments Download
M media/mp4/mp4_stream_parser_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
acolwell GONE FROM CHROMIUM
Attempt two.. Forgot to add config_change_pending_ member initializers. Inital patch set is what was LGTMed ...
8 years, 4 months ago (2012-08-21 21:19:08 UTC) #1
Ami GONE FROM CHROMIUM
lgtm
8 years, 4 months ago (2012-08-21 21:20:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/10828425/2001
8 years, 4 months ago (2012-08-21 21:20:59 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-21 23:10:19 UTC) #4
Try job failure for 10828425-2001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698