Issue 10828423: Fix a Windows crash bug with javascript alerts from extension popups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828423: Fix a Windows crash bug with javascript alerts from extension popups. (Closed)

Created:
8 years, 4 months ago by Matt Perry

Modified:
8 years, 4 months ago

Reviewers:
Avi (use Gerrit), Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix a Windows crash bug with javascript alerts from extension popups. BUG=137707 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152716

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/app_modal_dialogs/app_modal_dialog.cc	View		2 chunks	+7 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Matt Perry

avi: please review ben: adding you because there's a scary warning on the CompleteDialog calls ...

8 years, 4 months ago (2012-08-21 19:19:49 UTC) #1

Avi (use Gerrit)

The fix idea and code LGTM; I don't know enough about how Views works, though, ...

8 years, 4 months ago (2012-08-21 19:23:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10828423/1

8 years, 4 months ago (2012-08-21 21:46:21 UTC) #4

Change committed as 152716