Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 10828420: Prepare render_widget_fullscreen_pepper.cc's WebWidget implementation for https://bugs.webkit.org/s… (Closed)

Created:
8 years, 4 months ago by abarth-chromium
Modified:
8 years, 4 months ago
Reviewers:
jamesr, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Prepare render_widget_fullscreen_pepper.cc's WebWidget implementation for https://bugs.webkit.org/show_bug.cgi?id=92043 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152663

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/renderer/render_widget_fullscreen_pepper.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
abarth-chromium
8 years, 4 months ago (2012-08-21 17:21:33 UTC) #1
piman
https://chromiumcodereview.appspot.com/10828420/diff/1/content/renderer/render_widget_fullscreen_pepper.cc File content/renderer/render_widget_fullscreen_pepper.cc (right): https://chromiumcodereview.appspot.com/10828420/diff/1/content/renderer/render_widget_fullscreen_pepper.cc#newcode114 content/renderer/render_widget_fullscreen_pepper.cc:114: PaintOptions = ReadbackFromCompositorIfAvailable) { nit: I don't think the ...
8 years, 4 months ago (2012-08-21 17:28:34 UTC) #2
abarth-chromium
Done
8 years, 4 months ago (2012-08-21 17:53:14 UTC) #3
piman
lgtm
8 years, 4 months ago (2012-08-21 18:00:42 UTC) #4
abarth-chromium
Thanks!
8 years, 4 months ago (2012-08-21 18:05:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/10828420/4002
8 years, 4 months ago (2012-08-21 18:06:58 UTC) #6
commit-bot: I haz the power
Try job failure for 10828420-4002 (retry) on linux_chromeos for steps "interactive_ui_tests, browser_tests, unit_tests". It's a ...
8 years, 4 months ago (2012-08-21 18:57:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/10828420/4002
8 years, 4 months ago (2012-08-21 19:03:12 UTC) #8
commit-bot: I haz the power
Try job failure for 10828420-4002 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-21 20:38:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/10828420/4002
8 years, 4 months ago (2012-08-21 20:46:15 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-21 23:07:28 UTC) #11
Change committed as 152663

Powered by Google App Engine
This is Rietveld 408576698