Small changes to get the compilation size of code importing dart:html shorter.

lib/compiler/implementation/lib/native_helper.dart

Index: lib/compiler/implementation/lib/native_helper.dart
===================================================================
--- lib/compiler/implementation/lib/native_helper.dart	(revision 11028)
+++ lib/compiler/implementation/lib/native_helper.dart	(working copy)
@@ -11,7 +11,7 @@
 }
 
 String typeNameInSafari(obj) {
-  String name = constructorNameFallback(obj);
+  String name = JS('String', '#', constructorNameFallback(obj));
   // Safari is very similar to Chrome.
   if (name == 'Window') return 'DOMWindow';
   if (name == 'CanvasPixelArray') return 'Uint8ClampedArray';
@@ -20,13 +20,13 @@
 }
 
 String typeNameInOpera(obj) {
-  String name = constructorNameFallback(obj);
+  String name = JS('String', '#', constructorNameFallback(obj));
   if (name == 'Window') return 'DOMWindow';
   return name;
 }
 
 String typeNameInFirefox(obj) {
-  String name = constructorNameFallback(obj);
+  String name = JS('String', '#', constructorNameFallback(obj));
   if (name == 'Window') return 'DOMWindow';
   if (name == 'Document') return 'HTMLDocument';
   if (name == 'XMLDocument') return 'Document';
@@ -35,7 +35,7 @@
 }
 
 String typeNameInIE(obj) {
-  String name = constructorNameFallback(obj);
+  String name = JS('String', '#', constructorNameFallback(obj));
   if (name == 'Window') return 'DOMWindow';
   if (name == 'Document') {
     // IE calls both HTML and XML documents 'Document', so we check for the
@@ -65,17 +65,22 @@
     // the constructor name even for more specialized objects so
     // we have to fall through to the toString() based implementation
     // below in that case.
-    if (JS('String', "typeof(#)", name) === 'string'
-        && !name.isEmpty()
+    if (name is String
+        && name !== ''
         && name !== 'Object'
         && name !== 'Function.prototype') {  // Can happen in Opera.
       return name;
     }
   }
   String string = JS('String', 'Object.prototype.toString.call(#)', obj);
-  return string.substring(8, string.length - 1);
+  return JS('String', '#.substring(8, # - 1)', string, string.length);
 }
 
+// TODO(ngeoffray): stop using this method once our optimizers can
+// change str1.contains(str2) into str1.indexOf(str2) != -1.
+bool contains(String userAgent, String name) {
+  return JS('bool', '#.indexOf(#) != -1', userAgent, name);
+}
 
 /**
  * Returns the function to use to get the type name of an object.
@@ -85,15 +90,15 @@
   if (JS('String', 'typeof(navigator)') !== 'object') return typeNameInChrome;
 
   String userAgent = JS('String', "navigator.userAgent");
-  if (userAgent.contains(const RegExp('Chrome|DumpRenderTree'))) {
+  if (contains(userAgent, 'Chrome') || contains(userAgent, 'DumpRenderTree')) {
     return typeNameInChrome;
-  } else if (userAgent.contains('Firefox')) {
+  } else if (contains(userAgent, 'Firefox')) {
     return typeNameInFirefox;
-  } else if (userAgent.contains('MSIE')) {
+  } else if (contains(userAgent, 'MSIE')) {
     return typeNameInIE;
-  } else if (userAgent.contains('Opera')) {
+  } else if (contains(userAgent, 'Opera')) {
     return typeNameInOpera;
-  } else if (userAgent.contains('Safari')) {
+  } else if (contains(userAgent, 'Safari')) {
     return typeNameInSafari;
   } else {
     return constructorNameFallback;
@@ -116,7 +121,7 @@
 }
 
 String toStringForNativeObject(var obj) {
-  return 'Instance of ${getTypeNameOf(obj)}';
+  return 'Instance of '.concat(JS('String', '#', getTypeNameOf(obj)));

[kasperl, 2012/08/21 13:24:51]

Shouldn't interpolation be okay as long as we know that the type of the
getTypeNameOf is a string? It is much more readable using interpolation. If you
need to keep it like this, it deserves a comment.

[ngeoffray, 2012/08/23 14:06:02]

Changed to use back interpolation, and forcing the type of getTypeNameOf(obj) to
be of String.

 }
 
 /**
@@ -131,14 +136,6 @@
 }
 
 /**
- * Helper method to throw a [NoSuchMethodException] for a invalid call
- * on a native object.
- */
-void throwNoSuchMethod(obj, name, arguments) {
-  throw new NoSuchMethodException(obj, name, arguments);
-}
-
-/**
  * This method looks up the type name of [obj] in [methods]. [methods]
  * is a Javascript object. If it cannot find it, it looks into the
  * [_dynamicMetadata] array. If the method can still not be found, it
@@ -157,10 +154,10 @@
   var method = JS('var', '#[#]', methods, tag);
 
   if (method === null && _dynamicMetadata !== null) {
-    for (int i = 0; i < _dynamicMetadata.length; i++) {
-      MetaInfo entry = _dynamicMetadata[i];
-      if (entry.set.contains(tag)) {
-        method = JS('var', '#[#]', methods, entry.tag);
+    for (int i = 0; i < JS('int', '#.length', _dynamicMetadata); i++) {

[kasperl, 2012/08/21 13:24:51]

Florian landed support for very basic inlining. Would it make sense to start
adding top-level inlinable methods for some of these JS uses to give them a more
saying name?

[ngeoffray, 2012/08/23 14:06:02]

After landing Florian's changes, I can confirm that the top-level JS methods are
inlined. I will refactor our code in js_helper to have these helpers in another
CL.

+      MetaInfo entry = JS('MetaInfo', '#[#]', _dynamicMetadata, i);
+      if (JS('bool', '#[#]', entry._set, tag)) {
+        method = JS('var', '#[#]', methods, entry._tag);
         if (method !== null) break;
       }
     }
@@ -179,12 +176,12 @@
     method = JS('var',
         'function () {'
           'if (Object.getPrototypeOf(this) === #) {'
-            '#(this, #, Array.prototype.slice.call(arguments));'
+            'throw new TypeError(# + " is not a function");'
           '} else {'
             'return Object.prototype[#].apply(this, arguments);'
           '}'
         '}',
-      proto, DART_CLOSURE_TO_JS(throwNoSuchMethod), name, name);
+      proto, name, name);
   }
 
   if (JS('bool', '!#.hasOwnProperty(#)', proto, name)) {
@@ -243,20 +240,20 @@
   /**
    * The type name this [MetaInfo] relates to.
    */
-  String tag;
+  String _tag;
 
   /**
    * A string containing the names of subtypes of [tag], separated by
    * '|'.
    */
-  String tags;
+  String _tags;
 
   /**
    * A list of names of subtypes of [tag].
    */
-  Set<String> set;
+  Object _set;
 
-  MetaInfo(this.tag, this.tags, this.set);
+  MetaInfo(this._tag, this._tags, this._set);
 }
 
 List<MetaInfo> get _dynamicMetadata {
@@ -288,13 +285,13 @@
  */
 List <MetaInfo> buildDynamicMetadata(List<List<String>> inputTable) {
   List<MetaInfo> result = <MetaInfo>[];
-  for (int i = 0; i < inputTable.length; i++) {
-    String tag = inputTable[i][0];
-    String tags = inputTable[i][1];
-    Set<String> set = new Set<String>();
+  for (int i = 0; i < JS('int', '#.length', inputTable); i++) {
+    String tag = JS('String', '#[#][0]', inputTable, i);
+    String tags = JS('String', '#[#][1]', inputTable, i);
+    var set = JS('var', '{}');
     List<String> tagNames = tags.split('|');
-    for (int j = 0; j < tagNames.length; j++) {
-      set.add(tagNames[j]);
+    for (int j = 0; j < JS('int', '#.length', tagNames); j++) {
+      JS('void', '#[#[#]] = true', set, tagNames, j);
     }
     result.add(new MetaInfo(tag, tags, set));
   }