Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: runtime/vm/intermediate_language.h

Issue 10828414: Fix a bug in Equals for UseVal and ConstantVal. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_INTERMEDIATE_LANGUAGE_H_ 5 #ifndef VM_INTERMEDIATE_LANGUAGE_H_
6 #define VM_INTERMEDIATE_LANGUAGE_H_ 6 #define VM_INTERMEDIATE_LANGUAGE_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/ast.h" 9 #include "vm/ast.h"
10 #include "vm/growable_array.h" 10 #include "vm/growable_array.h"
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 387
388 virtual bool CanDeoptimize() const { return false; } 388 virtual bool CanDeoptimize() const { return false; }
389 389
390 UseVal* next_use() const { return next_use_; } 390 UseVal* next_use() const { return next_use_; }
391 UseVal* previous_use() const { return previous_use_; } 391 UseVal* previous_use() const { return previous_use_; }
392 virtual void RemoveFromUseList(); 392 virtual void RemoveFromUseList();
393 virtual void RemoveInputUses() { RemoveFromUseList(); } 393 virtual void RemoveInputUses() { RemoveFromUseList(); }
394 394
395 virtual intptr_t ResultCid() const; 395 virtual intptr_t ResultCid() const;
396 396
397 virtual bool AttributesEqual(Computation* other) const;
398
397 private: 399 private:
398 void AddToUseList(); 400 void AddToUseList();
399 Definition* definition_; 401 Definition* definition_;
400 UseVal* next_use_; 402 UseVal* next_use_;
401 UseVal* previous_use_; 403 UseVal* previous_use_;
402 404
403 friend class Definition; 405 friend class Definition;
404 406
405 DISALLOW_COPY_AND_ASSIGN(UseVal); 407 DISALLOW_COPY_AND_ASSIGN(UseVal);
406 }; 408 };
(...skipping 17 matching lines...) Expand all
424 426
425 // Returns true if the value represents constant null. 427 // Returns true if the value represents constant null.
426 virtual bool BindsToConstantNull() const { return value().IsNull(); } 428 virtual bool BindsToConstantNull() const { return value().IsNull(); }
427 429
428 virtual bool CanDeoptimize() const { return false; } 430 virtual bool CanDeoptimize() const { return false; }
429 431
430 virtual void RemoveFromUseList() { } 432 virtual void RemoveFromUseList() { }
431 433
432 virtual intptr_t ResultCid() const; 434 virtual intptr_t ResultCid() const;
433 435
436 virtual bool AttributesEqual(Computation* other) const;
437
434 private: 438 private:
435 const Object& value_; 439 const Object& value_;
436 440
437 DISALLOW_COPY_AND_ASSIGN(ConstantVal); 441 DISALLOW_COPY_AND_ASSIGN(ConstantVal);
438 }; 442 };
439 443
440 #undef DECLARE_VALUE 444 #undef DECLARE_VALUE
441 445
442 446
443 class AssertAssignableComp : public TemplateComputation<3> { 447 class AssertAssignableComp : public TemplateComputation<3> {
(...skipping 2576 matching lines...) Expand 10 before | Expand all | Expand 10 after
3020 ForwardInstructionIterator* current_iterator_; 3024 ForwardInstructionIterator* current_iterator_;
3021 3025
3022 private: 3026 private:
3023 DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor); 3027 DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor);
3024 }; 3028 };
3025 3029
3026 3030
3027 } // namespace dart 3031 } // namespace dart
3028 3032
3029 #endif // VM_INTERMEDIATE_LANGUAGE_H_ 3033 #endif // VM_INTERMEDIATE_LANGUAGE_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698