lib/compiler/implementation/compiler.dart - Issue 10828413: Only add JS once, and not to very single patched library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/compiler.dart

Issue 10828413: Only add JS once, and not to very single patched library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebased. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/compiler.dart

diff --git a/lib/compiler/implementation/compiler.dart b/lib/compiler/implementation/compiler.dart

index 304dab8a47470cb23137f2603cb384a66a64e0a2..2a9ea4687a167511ca197463d1223ea53e700c68 100644

--- a/lib/compiler/implementation/compiler.dart

+++ b/lib/compiler/implementation/compiler.dart

@@ -379,9 +379,7 @@ class Compiler implements DiagnosticListener {

if (library.isPatched) return;

Uri patchUri = resolvePatchUri(dartLibraryPath);

if (patchUri !== null) {

- patchParser.patchLibrary(patchUri, library);

- // We allow foreign functions in patched libraries.

- addForeignFunctions(library); // Is safe even if already added.

+ patchParser.patchLibrary(patchUri, library);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »