Implement class hierarchy analysis in the VM.

Implement class hierarchy analysis in the VM.
Add test.
Committed: https://code.google.com/p/dart/source/detail?r=11006

[srdjan, 2012-08-20 22:47:15]

LGTM with questions

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table.cc
File runtime/vm/class_table.cc (right):

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:101: static bool
ContainsCid(ZoneGrowableArray<intptr_t>* cids, intptr_t cid) {
COde below would look simpler if you change cids to be constant reference.

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:112: static void
CollectSubclassIds(ZoneGrowableArray<intptr_t>* cids,
For later: maybe we should create a hash_set<intptr_t> if we decide to use STLs.

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:115:
GrowableObjectArray::Handle(cls.direct_subclasses());
How about : if (cls_direct_subclasses.IsNull()) return;

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:134: ASSERT(!cls.IsNull());
ASSERT(cls.IsInstance()) ?

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:135: ZoneGrowableArray<intptr_t>* ids = new
ZoneGrowableArray<intptr_t>(2);
Why 2? If you do not specify anything, the data does not get allocated until
really needed.

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:145: ZoneGrowableArray<Function*>* functions = new
ZoneGrowableArray<Function*>(2);
ditto

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:150: ASSERT(cid != kObjectCid);
Assert not correct

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:152: cls = At(cid);
ASSERT(cls.IsInstance()).

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:168: ZoneGrowableArray<intptr_t>* cids = new
ZoneGrowableArray<intptr_t>(4);
ditto.

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:1864: ASSERT(id() != kObjectCid);
AS discussed need a different cid.

[regis, 2012-08-20 23:37:21]

Thanks!

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table.cc
File runtime/vm/class_table.cc (right):

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:101: static bool
ContainsCid(ZoneGrowableArray<intptr_t>* cids, intptr_t cid) {
On 2012/08/20 22:47:16, srdjan wrote:
> COde below would look simpler if you change cids to be constant reference.

Done.

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:112: static void
CollectSubclassIds(ZoneGrowableArray<intptr_t>* cids,
On 2012/08/20 22:47:16, srdjan wrote:
> For later: maybe we should create a hash_set<intptr_t> if we decide to use
STLs.

OK

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:115:
GrowableObjectArray::Handle(cls.direct_subclasses());
On 2012/08/20 22:47:16, srdjan wrote:
> How about : if (cls_direct_subclasses.IsNull()) return;

Done.

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:134: ASSERT(!cls.IsNull());
On 2012/08/20 22:47:16, srdjan wrote:
> ASSERT(cls.IsInstance()) ?

You can use IsInstance() on handles of objects. Here, we have a class. Once we
have kDartObjectCid, we can assert cid > kDartObjectCid.

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:135: ZoneGrowableArray<intptr_t>* ids = new
ZoneGrowableArray<intptr_t>(2);
On 2012/08/20 22:47:16, srdjan wrote:
> Why 2? If you do not specify anything, the data does not get allocated until
> really needed.

Done.

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:145: ZoneGrowableArray<Function*>* functions = new
ZoneGrowableArray<Function*>(2);
On 2012/08/20 22:47:16, srdjan wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:150: ASSERT(cid != kObjectCid);
On 2012/08/20 22:47:16, srdjan wrote:
> Assert not correct

We do not yet have kDartObjectCid. I've added a TODO and changed the ASSERT.

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:152: cls = At(cid);
On 2012/08/20 22:47:16, srdjan wrote:
> ASSERT(cls.IsInstance()).

Done.

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:168: ZoneGrowableArray<intptr_t>* cids = new
ZoneGrowableArray<intptr_t>(4);
On 2012/08/20 22:47:16, srdjan wrote:
> ditto.

Done.

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/10828399/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:1864: ASSERT(id() != kObjectCid);
On 2012/08/20 22:47:16, srdjan wrote:
> AS discussed need a different cid.

Changed assert and added TODO.