Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3899)

Unified Diff: build/common.gypi

Issue 10828396: Move the gyp variables used for grit defines on android to actually work. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: enable_printing is also used as a grit_defines Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c038b9d8b5d6fb6f9e4f21f24ddab09aa8b57f51..481c26d02c9dabe0e2b6d2f772d4359e0ad3a95c 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -456,8 +456,11 @@
}],
['OS=="android"', {
- 'proprietary_codecs%': 1,
+ 'enable_extensions%': 0,
+ 'enable_printing%': 0,
+ 'enable_themes%': 0,
'enable_webrtc%': 0,
+ 'proprietary_codecs%': 1,
'remoting%': 0,
}],
@@ -952,9 +955,7 @@
'configuration_policy%': 0,
'input_speech%': 0,
'enable_web_intents%': 0,
- 'enable_extensions%': 0,
'enable_automation%': 0,
- 'enable_printing%': 0,
'java_bridge%': 1,
'build_ffmpegsumo%': 0,
'linux_use_tcmalloc%': 0,
@@ -962,9 +963,6 @@
# Disable Native Client.
'disable_nacl%': 1,
- # Android does not support themes.
- 'enable_themes%': 0,
-
# Android does not support background apps.
'enable_background%': 0,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698