Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10828393: Fix depot_tools presubmit check for ubuntu 12.04. (Closed)

Created:
8 years, 4 months ago by M-A Ruel
Modified:
8 years, 4 months ago
Reviewers:
cmp
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org
Visibility:
Public.

Description

Fix depot_tools presubmit check for ubuntu 12.04. R=cmp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M testing_support/super_mox.py View 1 chunk +2 lines, -1 line 0 comments Download
M tests/presubmit_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
8 years, 4 months ago (2012-08-20 19:27:17 UTC) #1
cmp
lgtm I assume we will continue to use Lucid for the CQ and presubmit checks ...
8 years, 4 months ago (2012-08-22 07:06:11 UTC) #2
M-A Ruel
On 2012/08/22 07:06:11, cmp wrote: > lgtm > > I assume we will continue to ...
8 years, 4 months ago (2012-08-22 11:45:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10828393/1
8 years, 4 months ago (2012-08-22 11:45:56 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-22 11:48:29 UTC) #5 
Change committed as 152752

Powered by Google App Engine
This is Rietveld 408576698