Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: chrome/test/nacl_test_injection/buildbot_nacl_integration.py

Issue 10828388: NaCl: Disable Breakpad tests on 32-bit Windows because they are flaky (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/nacl_test_injection/buildbot_nacl_integration.py
diff --git a/chrome/test/nacl_test_injection/buildbot_nacl_integration.py b/chrome/test/nacl_test_injection/buildbot_nacl_integration.py
index 74a1b5a952aa7ce8b35ca53b3e517516161ec089..380e573aac8be588c9d503a6216c61c39c5a5a45 100755
--- a/chrome/test/nacl_test_injection/buildbot_nacl_integration.py
+++ b/chrome/test/nacl_test_injection/buildbot_nacl_integration.py
@@ -12,6 +12,12 @@ def Main(args):
pwd = os.environ.get('PWD', '')
is_integration_bot = 'nacl-chrome' in pwd
+ # This environment variable check mimics what
+ # buildbot_chrome_nacl_stage.py does.
+ is_win64 = (sys.platform in ('win32', 'cygwin') and
+ ('64' in os.environ.get('PROCESSOR_ARCHITECTURE', '') or
+ '64' in os.environ.get('PROCESSOR_ARCHITEW6432', '')))
+
# On the main Chrome waterfall, we may need to control where the tests are
# run.
# If there is serious skew in the PPAPI interface that causes all of
@@ -60,6 +66,18 @@ def Main(args):
# See http://crbug.com/132395
tests_to_disable.append('run_inbrowser_test_runner')
+ if sys.platform in ('win32', 'cygwin') and not is_win64:
+ # The Breakpad tests have started failing on 32-bit Windows (but
+ # not 64-bit Windows) because Chromium is producing an excess
+ # crash dump.
+ # See http://code.google.com/p/chromium/issues/detail?id=143413
+ # TODO(mseaborn): Change the tests to ignore the excess crash
+ # dump until we find out what is causing it.
+ tests_to_disable.extends([
+ 'run_inbrowser_trusted_crash_in_startup_test',
+ 'run_inbrowser_crash_in_syscall_test',
+ 'run_inbrowser_untrusted_crash_test',
+ ])
if sys.platform in ('win32', 'cygwin'):
tests_to_disable.append('run_ppapi_ppp_input_event_browser_test')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698