Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10828385: Rename DocumentsServiceInterface to DriveServiceInterface. (Closed)

Created:
8 years, 4 months ago by kochi
Modified:
8 years, 4 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, kinuko, Daniel Erat, kinaba
Visibility:
Public.

Description

Rename DocumentsServiceInterface to DriveServiceInterface. This Change applies on top of https://chromiumcodereview.appspot.com/10829375/ (not yet committed). BUG=143661 TEST=pass all existing tests, manually run filebrowser. TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152512

Patch Set 1 : . #

Patch Set 2 : Update comments. #

Patch Set 3 : rebase. #

Total comments: 3

Patch Set 4 : Fix unnecessary includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -843 lines) Patch
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 6 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/chromeos/gdata/documents_service_interface.h View 1 chunk +0 lines, -201 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_api_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/gdata/drive_service_interface.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_task_executor.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_download_observer.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 1 2 13 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc View 1 32 chunks +60 lines, -61 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operations.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_protocol_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_system_service.h View 5 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_system_service.cc View 1 2 7 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_upload_file_info.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_uploader.h View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_uploader.cc View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_wapi_feed_loader.h View 1 6 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_wapi_feed_loader.cc View 1 2 8 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_wapi_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/chromeos/gdata/mock_documents_service.h View 1 chunk +0 lines, -195 lines 0 comments Download
D chrome/browser/chromeos/gdata/mock_documents_service.cc View 1 chunk +0 lines, -198 lines 0 comments Download
A + chrome/browser/chromeos/gdata/mock_drive_service.h View 2 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/chromeos/gdata/mock_drive_service.cc View 11 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/gdata/operations_base.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kochi
Hi Satoru, Could you review this? This applies on top of the previous CL: https://chromiumcodereview.appspot.com/10829375/ ...
8 years, 4 months ago (2012-08-20 10:59:09 UTC) #1
satorux1
LGTM
8 years, 4 months ago (2012-08-20 16:56:30 UTC) #2
kochi
Thanks for the review! https://chromiumcodereview.appspot.com/10828385/diff/2006/chrome/browser/chromeos/gdata/gdata_download_observer.cc File chrome/browser/chromeos/gdata/gdata_download_observer.cc (right): https://chromiumcodereview.appspot.com/10828385/diff/2006/chrome/browser/chromeos/gdata/gdata_download_observer.cc#newcode18 chrome/browser/chromeos/gdata/gdata_download_observer.cc:18: #include "chrome/browser/chromeos/gdata/gdata_wapi_service.h" Looks like an ...
8 years, 4 months ago (2012-08-21 02:34:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/10828385/6035
8 years, 4 months ago (2012-08-21 02:42:08 UTC) #4
commit-bot: I haz the power
Presubmit check for 10828385-6035 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-21 02:42:28 UTC) #5
kochi
Adding ben@chromium.org for gypi OWNERS review.
8 years, 4 months ago (2012-08-21 02:44:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/10828385/6035
8 years, 4 months ago (2012-08-21 02:44:23 UTC) #7
commit-bot: I haz the power
Change committed as 152512
8 years, 4 months ago (2012-08-21 05:03:57 UTC) #8
Ben Goodger (Google)
8 years, 4 months ago (2012-08-21 16:00:11 UTC) #9 
lgtm

Powered by Google App Engine
This is Rietveld 408576698