Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10828382: Cleanup: Don't close single tags. (Closed)

Created:
8 years, 4 months ago by James Hawkins
Modified:
8 years, 2 months ago
Reviewers:
csilv, eroman
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, tfarina, eroman, sreeram, gideonwald, dominich, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), David Black, Shishir, oshima+watch_chromium.org, stevenjb+watch_chromium.org, mmenke, Jered
Visibility:
Public.

Description

Cleanup: Don't close single tags. BUG=none R=csilv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152275

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review fixes. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -181 lines) Patch
M chrome/browser/resources/about_memory.html View 3 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/resources/about_memory_linux.html View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/about_memory_mac.html View 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/resources/about_stats.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/about_version.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/about_sys.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/guest_session_tab.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/host_registration_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/mobile_setup.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/notification_icon_link.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/cloud_print/cloud_print_setup_login.html View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/extensions/extension_commands_overlay.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/pack_extension_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/feedback.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/gallery.html View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/file_manager/mediaplayer.html View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/file_manager/photo_import.html View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/file_manager/video_player.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/flags.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/incognito_tab.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/inspect/inspect.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/instant/instant.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/media_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/capture_view.html View 1 chunk +2 lines, -4 lines 2 comments Download
M chrome/browser/resources/net_internals/dns_view.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/net_internals/events_view.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/net_internals/hsts_view.html View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/net_internals/import_view.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/proxy_view.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/net_internals/sockets_view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/net_internals/status_view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/net_internals/test_view.html View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/net_internals/timeline_view.html View 1 1 chunk +17 lines, -17 lines 0 comments Download
M chrome/browser/resources/notification_icon.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp_android/new_tab.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/performance_monitor/chart.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/plugins.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/previewarea/margin_control.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 1 chunk +17 lines, -17 lines 0 comments Download
M chrome/browser/resources/print_preview/search/destination_list_item.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/search/destination_search.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/search/fedex_tos.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/search/search_box.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/color_settings.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/copies_settings.html View 1 chunk +5 lines, -8 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/destination_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/layout_settings.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/other_options_settings.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/page_settings.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/profiler/profiler.html View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/quota_internals/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/sync_internals/about.html View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/sync_internals/notifications.html View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
James Hawkins
8 years, 4 months ago (2012-08-18 13:46:26 UTC) #1
csilv
http://codereview.chromium.org/10828382/diff/1/chrome/browser/resources/extensions/extension_commands_overlay.html File chrome/browser/resources/extensions/extension_commands_overlay.html (right): http://codereview.chromium.org/10828382/diff/1/chrome/browser/resources/extensions/extension_commands_overlay.html#newcode44 chrome/browser/resources/extensions/extension_commands_overlay.html:44: <span class="command-shortcut clearable" tabindex="0"> needs </span> http://codereview.chromium.org/10828382/diff/1/chrome/browser/resources/net_internals/timeline_view.html File chrome/browser/resources/net_internals/timeline_view.html ...
8 years, 4 months ago (2012-08-18 20:32:26 UTC) #2
James Hawkins
http://codereview.chromium.org/10828382/diff/1/chrome/browser/resources/extensions/extension_commands_overlay.html File chrome/browser/resources/extensions/extension_commands_overlay.html (right): http://codereview.chromium.org/10828382/diff/1/chrome/browser/resources/extensions/extension_commands_overlay.html#newcode44 chrome/browser/resources/extensions/extension_commands_overlay.html:44: <span class="command-shortcut clearable" tabindex="0"> On 2012/08/18 20:32:26, csilv wrote: ...
8 years, 4 months ago (2012-08-19 00:32:06 UTC) #3
csilv
lgtm
8 years, 4 months ago (2012-08-19 00:45:50 UTC) #4
eroman
https://chromiumcodereview.appspot.com/10828382/diff/6001/chrome/browser/resources/net_internals/capture_view.html File chrome/browser/resources/net_internals/capture_view.html (left): https://chromiumcodereview.appspot.com/10828382/diff/6001/chrome/browser/resources/net_internals/capture_view.html#oldcode10 chrome/browser/resources/net_internals/capture_view.html:10: <p /> FYI, removing this caused a presentation difference ...
8 years, 3 months ago (2012-09-24 18:23:58 UTC) #5
James Hawkins
8 years, 2 months ago (2012-09-25 16:23:04 UTC) #6 
https://chromiumcodereview.appspot.com/10828382/diff/6001/chrome/browser/reso...
File chrome/browser/resources/net_internals/capture_view.html (left):

https://chromiumcodereview.appspot.com/10828382/diff/6001/chrome/browser/reso...
chrome/browser/resources/net_internals/capture_view.html:10: <p />
On 2012/09/24 18:23:59, eroman wrote:
> FYI, removing this caused a presentation difference (it was acting as a
spacer).
> 
> I'll add back something to restore the earlier look.
> 
> BTW, is there any presubmit script to prevent this style from regressing?
> Cheers.

Paragraphs and breaks should not be used for spacing.  CSS styling on the
relevant content is how this should be accomplished.

Powered by Google App Engine
This is Rietveld 408576698