Issue 10828380: Convert the pdf PerformPDFAction pyauto test to a browser test. While at it, verify that…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828380: Convert the pdf PerformPDFAction pyauto test to a browser test. While at it, verify that… (Closed)

Created:
8 years, 4 months ago by jam

Modified:
8 years, 4 months ago

Reviewers:
cevans, Chris Evans

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Convert the pdf PerformPDFAction pyauto test to a browser test. While at it, verify that clicking the buttons changed the zoom. testPDFRunner is a duplicate of PDFBrowserTest.SLOW_Loading so not porting it. BUG=143637 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152330

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -93 lines)			Patch
M	chrome/browser/ui/pdf/pdf_browsertest.cc	View	1 chunk	+31 lines, -0 lines	2 comments	Download
M	chrome/test/functional/PYAUTO_TESTS	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/test/functional/pdf.py	View	1 chunk	+0 lines, -92 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

btw I also have a change to delete all the duplicate pdf files from src-internal ...

8 years, 4 months ago (2012-08-18 00:42:44 UTC) #2

cevans

LGTM with question http://codereview.chromium.org/10828380/diff/1/chrome/browser/ui/pdf/pdf_browsertest.cc File chrome/browser/ui/pdf/pdf_browsertest.cc (right): http://codereview.chromium.org/10828380/diff/1/chrome/browser/ui/pdf/pdf_browsertest.cc#newcode374 chrome/browser/ui/pdf/pdf_browsertest.cc:374: ASSERT_NE(zoom1, zoom2); Is the width/height of ...

8 years, 4 months ago (2012-08-18 00:51:55 UTC) #3

jam

8 years, 4 months ago (2012-08-18 00:57:05 UTC) #4

http://codereview.chromium.org/10828380/diff/1/chrome/browser/ui/pdf/pdf_brow...
File chrome/browser/ui/pdf/pdf_browsertest.cc (right):

http://codereview.chromium.org/10828380/diff/1/chrome/browser/ui/pdf/pdf_brow...
chrome/browser/ui/pdf/pdf_browsertest.cc:374: ASSERT_NE(zoom1, zoom2);
On 2012/08/18 00:51:55, cevans wrote:
> Is the width/height of the browser window sufficiently deterministic in the
> BROWSER_TEST world that this won't accidentally fail?

Load() resizes the browser to 1000x600 and ensures that it's that big :)

Expand Messages | Collapse Messages