Issue 10828378: Convert the indexed db pyauto tests to content_browsertests.

Issue 10828378: Convert the indexed db pyauto tests to content_browsertests. (Closed)

Created:
8 years, 4 months ago by jam

Modified:
8 years, 4 months ago

Reviewers:
dgrogan, jsbell

CC:
chromium-reviews, Nirnimesh, jam, joi+watch-content_chromium.org, anantha, darin-cc_chromium.org, dyu1, dennis_jeffrey, jsbell

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Convert the indexed db pyauto tests to content_browsertests. BUG=140919, 143637 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152373

Patch Set 3 : #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -388 lines)			Patch
D	chrome/test/data/indexeddb/bug_90635.html	View		1 chunk	+0 lines, -11 lines	0 comments	Download
D	chrome/test/data/indexeddb/bug_90635.js	View		1 chunk	+0 lines, -66 lines	0 comments	Download
D	chrome/test/data/indexeddb/shared.js	View		1 chunk	+0 lines, -27 lines	0 comments	Download
D	chrome/test/data/indexeddb/version_change_blocked.html	View		1 chunk	+0 lines, -11 lines	0 comments	Download
D	chrome/test/data/indexeddb/version_change_blocked.js	View		1 chunk	+0 lines, -56 lines	0 comments	Download
D	chrome/test/data/indexeddb/version_change_crash.html	View		1 chunk	+0 lines, -11 lines	0 comments	Download
D	chrome/test/data/indexeddb/version_change_crash.js	View		1 chunk	+0 lines, -95 lines	0 comments	Download
M	chrome/test/functional/PYAUTO_TESTS	View	1 2	2 chunks	+0 lines, -2 lines	0 comments	Download
D	chrome/test/functional/indexeddb.py	View	1	1 chunk	+0 lines, -110 lines	0 comments	Download
M	content/browser/in_process_webkit/indexed_db_browsertest.cc	View		4 chunks	+70 lines, -0 lines	2 comments	Download
M	content/shell/shell.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
A +	content/test/data/indexeddb/bug_90635.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/test/data/indexeddb/bug_90635.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/test/data/indexeddb/shared.js	View		1 chunk	+1 line, -4 lines	0 comments	Download
A +	content/test/data/indexeddb/version_change_blocked.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/test/data/indexeddb/version_change_blocked.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/test/data/indexeddb/version_change_crash.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/test/data/indexeddb/version_change_crash.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

http://codereview.chromium.org/10828378/diff/6001/chrome/test/functional/PYAUTO_TESTS File chrome/test/functional/PYAUTO_TESTS (right): http://codereview.chromium.org/10828378/diff/6001/chrome/test/functional/PYAUTO_TESTS#newcode870 chrome/test/functional/PYAUTO_TESTS:870: '-indexeddb.IndexedDBTest.testVersionChangeCrashResilience', please remove this too

8 years, 4 months ago (2012-08-17 22:59:01 UTC) #3

jam

(switched reviewers to jsbell) http://codereview.chromium.org/10828378/diff/6001/chrome/test/functional/PYAUTO_TESTS File chrome/test/functional/PYAUTO_TESTS (right): http://codereview.chromium.org/10828378/diff/6001/chrome/test/functional/PYAUTO_TESTS#newcode870 chrome/test/functional/PYAUTO_TESTS:870: '-indexeddb.IndexedDBTest.testVersionChangeCrashResilience', On 2012/08/17 22:59:01, Nirnimesh ...

8 years, 4 months ago (2012-08-17 23:12:52 UTC) #4

dgrogan

lgtm You can use BUG=140919 for this. Josh would be the better reviewer but he's ...

8 years, 4 months ago (2012-08-17 23:41:27 UTC) #5

jam

8 years, 4 months ago (2012-08-18 00:45:10 UTC) #6

http://codereview.chromium.org/10828378/diff/12001/content/browser/in_process...
File content/browser/in_process_webkit/indexed_db_browsertest.cc (right):

http://codereview.chromium.org/10828378/diff/12001/content/browser/in_process...
content/browser/in_process_webkit/indexed_db_browsertest.cc:282:
shell()->web_contents()->GetRenderProcessHost()->GetHandle(), 0, true);
On 2012/08/17 23:41:27, dgrogan wrote:
> Could you annotate 0 and true with constants or comments a la kExitCode or /*
> wait */ ?

My preference is not to do this. I realize some developers like this, but I'm of
the opinion that if someone wants to know about what a parameter to a function
that they're not familiar with does, they can look at the header comments.
otherwise we're just duplicating those comments at every callsite.

Expand Messages | Collapse Messages