Issue 10828376: Refactor the GYP build for the NaCl smoke test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828376: Refactor the GYP build for the NaCl smoke test. (Closed)

Created:
8 years, 4 months ago by Nick Bray (chromium)

Modified:
8 years, 4 months ago

Reviewers:
bradnelson, bradn, brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Refactor the GYP build for the NaCl smoke test. This change should eliminate a lot of the cruft needed to build nexes for browser tests. This change also cleans up how browser_tests depends on the IRT. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2959 TEST= none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152231

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+153 lines, -93 lines)			Patch
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/nacl/nacl_browser_test.gypi	View	1 chunk	+146 lines, -0 lines	0 comments	Download
M	chrome/test/data/nacl/nacl_test_data.gyp	View	1 chunk	+6 lines, -92 lines	0 comments	Download
M	ppapi/ppapi_untrusted.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Nick Bray (chromium)

bradnelson as primary reviewer. brettw as owner for trivial GYP changes.

8 years, 4 months ago (2012-08-17 21:59:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/10828376/1

8 years, 4 months ago (2012-08-18 00:48:40 UTC) #4

Change committed as 152231