Deflakify DownloadExtensionTest by not depending on the icon loader

Deflakify DownloadExtensionTest by not depending on the icon loader
BUG=138211
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152454

[benjhayden, 2012-08-17 19:22:21]

Asanka, PTAL

[benjhayden, 2012-08-17 19:23:13]

Context:
DownloadExtensionTest_FileIcon_Active
DownloadExtensionTest_FileIcon_History
DownloadExtensionTest_SearchPauseResumeCancelGetFileIconIncognito
http://master.chrome.corp.google.com:8010/builders/lucid32/builds/244/steps/b...
http://master.chrome.corp.google.com:8010/builders/lucid64/builds/237/steps/b...

[asanka, 2012-08-17 20:35:36]

While this would certainly stop the tests from failing, I don't think it would
address the underlying issue.

Currently, there are no other tests that exercise the icon loading code. On
configurations where icon loading is broken, these tests will fail (see issue
http://crbug.com/102211). In theory if you were to open Chrome on such a system,
the downloads page wouldn't have any icons in it. So this failing test indicates
that the user experience would also be broken.

However, I'd agree with this CL on the basis that the download extension tests
shouldn't lose test coverage because of it.

http://codereview.chromium.org/10828372/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/downloads/downloads_api_unittest.cc (right):

http://codereview.chromium.org/10828372/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/downloads/downloads_api_unittest.cc:889: // The
test fails under ASan, see http://crbug.com/138211
You should re-enable these tests. The failure mode is the same.

[asanka, 2012-08-17 20:36:58]

Once you enable the tests, can you also try on the ASAN bots?

[benjhayden, 2012-08-17 21:35:56]

What are the asan trybot names?

http://codereview.chromium.org/10828372/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/downloads/downloads_api_unittest.cc (right):

http://codereview.chromium.org/10828372/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/downloads/downloads_api_unittest.cc:889: // The
test fails under ASan, see http://crbug.com/138211
On 2012/08/17 20:35:36, asanka wrote:
> You should re-enable these tests. The failure mode is the same.

Done.

[asanka, 2012-08-17 21:46:57]

On 2012/08/17 21:35:56, benjhayden_chromium wrote:
> What are the asan trybot names?

linux_asan, linux_chromeos_asan and mac_asan. Although the only bot that had
this problem is the linux_asan bot, which I think is the same configuration as
the lucid64 bot.

[benjhayden, 2012-08-19 21:02:33]

PTAL

[asanka, 2012-08-20 19:05:07]

LGTM

[commit-bot: I haz the power, 2012-08-20 21:20:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10828372/12002

[commit-bot: I haz the power, 2012-08-21 00:50:35]

Change committed as 152454