chrome/common/extensions/extension_manifest_constants.cc - Issue 10828363: Improve error message for insecure 'content_security_policy' manifest entries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_manifest_constants.cc

Issue 10828363: Improve error message for insecure 'content_security_policy' manifest entries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Tests. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/extension_manifest_constants.h ('k') | chrome/common/extensions/manifest_tests/extension_manifests_contentsecuritypolicy_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_manifest_constants.cc

diff --git a/chrome/common/extensions/extension_manifest_constants.cc b/chrome/common/extensions/extension_manifest_constants.cc

index ad5e4463af89a82b7a6fb50802c4e549f287ef97..d5fdb7b2084cca560eb4cd4b3446c061d22fe4d9 100644

--- a/chrome/common/extensions/extension_manifest_constants.cc

+++ b/chrome/common/extensions/extension_manifest_constants.cc

@@ -452,6 +452,11 @@ const char kInvalidWebURLs[] =

"Invalid value for 'app.urls'.";

const char kInvalidZipHash[] =

"Required key 'zip_hash' is missing or invalid.";

+const char kInsecureContentSecurityPolicy[] =

+ "Invalid value for 'content_security_policy': 'script-src' and 'object-src'"

+ " can only contain secure resources. You may whitelist HTTPS origins,"

+ " \"chrome-extension:\" resources, \"'self'\", http://127.0.0.1, and"

+ " http://localhost).";

abarth-chromium 2012/08/27 06:51:57 It's confusing when you're using single and when y

const char kLaunchPathAndExtentAreExclusive[] =

"The 'app.launch.local_path' and 'app.urls' keys cannot both be set.";

const char kLaunchPathAndURLAreExclusive[] =