chrome/common/extensions/extension.cc - Issue 10828363: Improve error message for insecure 'content_security_policy' manifest entries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 10828363: Improve error message for insecure 'content_security_policy' manifest entries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Tests. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/common/extensions/extension_manifest_constants.h » ('j') | chrome/common/extensions/extension_manifest_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index 03bba03247001607407bbad7e3a594fe3ba3d415..1e0c0862ae91a87e7411e3080dda50b682c95dda 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -2724,7 +2724,7 @@ bool Extension::LoadContentSecurityPolicy(string16* error) {

}

if (manifest_version_ >= 2 &&

!ContentSecurityPolicyIsSecure(content_security_policy)) {

- *error = ASCIIToUTF16(errors::kInvalidContentSecurityPolicy);

+ *error = ASCIIToUTF16(errors::kInsecureContentSecurityPolicy);

return false;

}