Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 10828357: [NaCl SDK] Fix template.mk to use spaces instead of tabs for non-recipe. (Closed)

Created:
8 years, 4 months ago by binji
Modified:
8 years, 4 months ago
Reviewers:
noelallen1
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

[NaCl SDK] Fix template.mk to check for missing html page inside recipe. I was seeing the error: "recipe commences before first target. Stop" http://www.gnu.org/software/make/manual/html_node/Error-Messages.html BUG=none TBR=noelallen@chromium.org NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152108

Patch Set 1 #

Patch Set 2 : check for valid page only when launching #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M native_client_sdk/src/build_tools/template.mk View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/10828357/1
8 years, 4 months ago (2012-08-16 23:17:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/10828357/3001
8 years, 4 months ago (2012-08-17 18:10:25 UTC) #2
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 18:11:57 UTC) #3
Change committed as 152108

Powered by Google App Engine
This is Rietveld 408576698