Issue 10828353: Chrome To Mobile Service refactoring and polish, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828353: Chrome To Mobile Service refactoring and polish, etc. (Closed)

Created:
8 years, 4 months ago by msw

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Chrome To Mobile Service refactoring and polish, etc. These cleanup changes were pulled out from: http://codereview.chromium.org/10834203 Use the cloud print device displayName instead of name. (these are editable names shown on the cloud print dash) Call NOTREACHED on any task posting failure. Extract UpdateCommandState utility function. Rename & refactor RefreshAccessToken->RequestAccessToken. Rename RequestSearch->RequestDeviceSearch. Make HasMobiles const; consolidate access_token_ DCHECKs. Misc comment updates. BUG=102709 TEST=No Chrome To Mobile regressions, device display names reflected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151995

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -56 lines)			Patch
M	chrome/browser/chrome_to_mobile_service.h	View	5 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/chrome_to_mobile_service.cc	View	14 chunks	+55 lines, -44 lines	0 comments	Download
M	chrome/browser/chrome_to_mobile_service_unittest.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10828353/1

8 years, 4 months ago (2012-08-16 20:01:28 UTC) #3

Change committed as 151995

Expand Messages | Collapse Messages