Per-host V8 histograms.

content/renderer/render_thread_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_thread_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
 #include <vector>
@@ skipping 141 matching lines @@
     return true;
   }
 
  private:
   std::string host_;
   double zoom_level_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewZoomer);
 };
 
-}  // namespace
+std::string HostToCustomHistogramSuffix(const std::string& host) {
+  if (host == "mail.google.com")
+    return ".gmail";
+  if (host == "docs.google.com" || host == "drive.google.com")
+    return ".docs";
+  if (host == "plus.google.com")
+    return ".plus";
+  return "";
+}
 
-static void* CreateHistogram(
+void* CreateHistogram(
     const char *name, int min, int max, size_t buckets) {
   if (min <= 0)
     min = 1;
+  std::string histogram_name = RenderThreadImpl::current()->
+      histogram_customizer()->ConvertToCustomHistogramName(name);
   base::Histogram* histogram = base::Histogram::FactoryGet(
-      name, min, max, buckets, base::Histogram::kUmaTargetedHistogramFlag);
+      histogram_name, min, max, buckets,
+      base::Histogram::kUmaTargetedHistogramFlag);
   return histogram;
 }
 
-static void AddHistogramSample(void* hist, int sample) {
+void AddHistogramSample(void* hist, int sample) {
   base::Histogram* histogram = static_cast<base::Histogram*>(hist);
   histogram->Add(sample);
 }
 
+}  // namespace
+
 class RenderThreadImpl::GpuVDAContextLostCallback
     : public WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback {
  public:
   GpuVDAContextLostCallback() {}
   virtual ~GpuVDAContextLostCallback() {}
   virtual void onContextLost() {
     ChildThread::current()->message_loop()->PostTask(FROM_HERE, base::Bind(
         &RenderThreadImpl::OnGpuVDAContextLoss));
   }
 };
 
+RenderThreadImpl::HistogramCustomizer::HistogramCustomizer() {
+  custom_histograms_.insert("V8.GCCompactor");
+  custom_histograms_.insert("V8.GCScavenger");
+  custom_histograms_.insert("V8.GCContext");
+  custom_histograms_.insert("V8.Parse");
+  custom_histograms_.insert("V8.ParseLazy");
+  custom_histograms_.insert("V8.PreParse");
+  custom_histograms_.insert("V8.Compile");
+  custom_histograms_.insert("V8.CompileEval");
+  custom_histograms_.insert("V8.CompileLazy");
+  custom_histograms_.insert("V8.MemoryExternalFragmentationTotal");

[jochen (gone - plz use gerrit), 2012/08/28 12:48:54]

for now, I think the following three histograms are what we want:

V8.MemoryExternalFragmentationTotal
V8.MemoryHeapSampleTotalCommitted
V8.MemoryHeapSampleTotalUsed

[marja, 2012/08/28 13:57:28]

Done.

+  custom_histograms_.insert("V8.MemoryExternalFragmentationOldPointerSpace");
+  custom_histograms_.insert("V8.MemoryExternalFragmentationOldDataSpace");
+  custom_histograms_.insert("V8.MemoryExternalFragmentationCodeSpace");
+  custom_histograms_.insert("V8.MemoryExternalFragmentationMapSpace");
+  custom_histograms_.insert("V8.MemoryExternalFragmentationCellSpace");
+  custom_histograms_.insert("V8.MemoryExternalFragmentationLoSpace");
+}
+
+RenderThreadImpl::HistogramCustomizer::~HistogramCustomizer() {}
+
+void RenderThreadImpl::HistogramCustomizer::RenderViewNavigatedToHost(
+    const std::string& host, size_t view_count) {
+  // Check if all RenderViews are displaying a page from the same host. If there
+  // is only one RenderView, the common host is this view's host. If there are
+  // many, check if this one shares the common host of the other
+  // RenderViews. It's ok to not detect some cases where the RenderViews share a
+  // common host. This information is only used for producing custom histograms.
+  if (view_count == 1)
+    SetCommonHost(host);
+  else if (host != common_host_)
+    SetCommonHost(std::string());
+}
+
+std::string RenderThreadImpl::HistogramCustomizer::ConvertToCustomHistogramName(
+    const char* histogram_name) const {
+  std::string name(histogram_name);
+  if (!common_host_histogram_suffix_.empty() &&
+      custom_histograms_.find(name) != custom_histograms_.end())
+    name += common_host_histogram_suffix_;
+  return name;
+}
+
+void RenderThreadImpl::HistogramCustomizer::SetCommonHost(
+    const std::string& host) {
+  if (host != common_host_) {
+    common_host_ = host;
+    common_host_histogram_suffix_ = HostToCustomHistogramSuffix(host);
+    v8::V8::SetCreateHistogramFunction(CreateHistogram);
+  }
+}
+
 RenderThreadImpl* RenderThreadImpl::current() {
   return lazy_tls.Pointer()->Get();
 }
 
 // When we run plugins in process, we actually run them on the render thread,
 // which means that we need to make the render thread pump UI events.
 RenderThreadImpl::RenderThreadImpl() {
   Init();
 }
 
@@ skipping 874 matching lines @@
 
 scoped_refptr<base::MessageLoopProxy>
 RenderThreadImpl::GetFileThreadMessageLoopProxy() {
   DCHECK(message_loop() == MessageLoop::current());
   if (!file_thread_.get()) {
     file_thread_.reset(new base::Thread("Renderer::FILE"));
     file_thread_->Start();
   }
   return file_thread_->message_loop_proxy();
 }