Issue 10828337: nacl-mounts: Fix build on newlib

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828337: nacl-mounts: Fix build on newlib (Closed)

Created:
8 years, 4 months ago by davidben

Modified:
8 years, 4 months ago

Reviewers:
eugenis, bradn

CC:
native-client-reviews_googlegroups.com

Base URL:
http://naclports.googlecode.com/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

nacl-mounts: Fix build on newlib select isn't available in the headers. Just ifdef out the test; it's not wrapped on newlib anyway. TEST=Build without NACL_GLIB=1 isn't stuck on unit tests

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	libraries/nacl-mounts/test.nacl/DevTest.cc	View		3 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bradn

Gonna fold something similar into this change: https://chromiumcodereview.appspot.com/10854174/ I think you've got your #ifdefs reversed ...

8 years, 4 months ago (2012-08-21 17:49:19 UTC) #3

Sorry head on backward, you're correct.
Merging as is.

Expand Messages | Collapse Messages