Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 10828336: chromeos: Remove CROS_FONTS_USING_BCI. (Closed)

Created:
8 years, 4 months ago by Daniel Erat
Modified:
8 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, Aaron Boodman, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org, tony, Zachary Kuznia, jungshik at Google
Visibility:
Public.

Description

chromeos: Remove CROS_FONTS_USING_BCI. This was a #define that was added when we were deciding whether we should use the bytecode interpreter or FreeType's autohinter when rendering UI text on Chrome OS. The text had different heights depending on which setting was used, so a bunch of constants were special-cased when BCI was enabled. We've been using the autohinter for a long time, and we'll need to update lots of newer code if we decide to switch to BCI someday. BUG=none TEST=UI text looks the same as before TBR=tony@chromium.org,davemoore@chromium.org,zork@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151928

Patch Set 1 #

Patch Set 2 : update media_galleries_dialog_views.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M build/build_config.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/helper.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/extensions/bundle_installed_bubble.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Daniel Erat
8 years, 4 months ago (2012-08-16 00:18:39 UTC) #1
Peter Kasting
LGTM, but also remove the reference in chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc that just got checked in today.
8 years, 4 months ago (2012-08-16 03:34:55 UTC) #2
Daniel Erat
Thanks! Done.
8 years, 4 months ago (2012-08-16 15:44:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10828336/4001
8 years, 4 months ago (2012-08-16 16:02:23 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 18:48:01 UTC) #5
Change committed as 151928

Powered by Google App Engine
This is Rietveld 408576698