Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 10828326: Fix TraceEventTestFixture flakiness (Closed)

Created:
8 years, 4 months ago by jbates
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix TraceEventTestFixture flakiness BUG=142804 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151851

Patch Set 1 #

Patch Set 2 : Fixed TraceEventAnalyzer Duration test #

Patch Set 3 : sharing HighResSleepForTraceTest between tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M base/base.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + base/debug/trace_event_unittest.h View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M base/debug/trace_event_unittest.cc View 1 2 6 chunks +14 lines, -6 lines 1 comment Download
M base/test/trace_event_analyzer_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jbates
8 years, 4 months ago (2012-08-15 17:47:14 UTC) #1
jar (doing other things)
LGTM https://chromiumcodereview.appspot.com/10828326/diff/5001/base/debug/trace_event_unittest.cc File base/debug/trace_event_unittest.cc (right): https://chromiumcodereview.appspot.com/10828326/diff/5001/base/debug/trace_event_unittest.cc#newcode642 base/debug/trace_event_unittest.cc:642: base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(1)); As per our discussion... it is very ...
8 years, 4 months ago (2012-08-16 01:23:35 UTC) #2
jbates
On 2012/08/16 01:23:35, jar wrote: > LGTM > > https://chromiumcodereview.appspot.com/10828326/diff/5001/base/debug/trace_event_unittest.cc > File base/debug/trace_event_unittest.cc (right): > ...
8 years, 4 months ago (2012-08-16 01:26:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbates@chromium.org/10828326/5001
8 years, 4 months ago (2012-08-16 01:27:21 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 04:32:51 UTC) #5
Change committed as 151851

Powered by Google App Engine
This is Rietveld 408576698