Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: runtime/vm/flow_graph_optimizer.h

Issue 10828319: Cleanup handling of NullType in type propagation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.h
===================================================================
--- runtime/vm/flow_graph_optimizer.h (revision 10781)
+++ runtime/vm/flow_graph_optimizer.h (working copy)
@@ -75,9 +75,11 @@
class FlowGraphTypePropagator : public FlowGraphVisitor {
public:
FlowGraphTypePropagator(const ParsedFunction& parsed_function,
- const GrowableArray<BlockEntryInstr*>& blocks)
+ const GrowableArray<BlockEntryInstr*>& blocks,
+ bool is_ssa)
: FlowGraphVisitor(blocks),
parsed_function_(parsed_function),
+ is_ssa_(is_ssa),
still_changing_(false) { }
virtual ~FlowGraphTypePropagator() { }
@@ -87,8 +89,8 @@
virtual void VisitAssertAssignable(AssertAssignableComp* comp,
BindInstr* instr);
- virtual void VisitAssertBoolean(AssertBooleanComp* comp,
- BindInstr* instr);
+ virtual void VisitAssertBoolean(AssertBooleanComp* comp, BindInstr* instr);
+ virtual void VisitInstanceOf(InstanceOfComp* comp, BindInstr* instr);
virtual void VisitGraphEntry(GraphEntryInstr* graph_entry);
virtual void VisitJoinEntry(JoinEntryInstr* join_entry);
@@ -98,6 +100,8 @@
private:
const ParsedFunction& parsed_function_;
+ const bool is_ssa_; // TODO(regis): Remove once virtual frame backend is
+ // removed.
bool still_changing_;
DISALLOW_COPY_AND_ASSIGN(FlowGraphTypePropagator);
};
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698