Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: runtime/vm/intermediate_language.h

Issue 10828319: Cleanup handling of NullType in type propagation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 10694)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -295,6 +295,11 @@
public:
Value() { }
+ // Returns true if the value is constant null.
+ bool IsConstantNull() const;
+
+ // Reminder: The type of the constant null is the bottom type, which is more
+ // specific than any type.
bool CompileTypeIsMoreSpecificThan(const AbstractType& dst_type) const;
virtual void RemoveFromUseList() = 0;
@@ -2882,9 +2887,13 @@
class FlowGraphVisitor : public ValueObject {
public:
explicit FlowGraphVisitor(const GrowableArray<BlockEntryInstr*>& block_order)
- : block_order_(block_order) { }
+ : block_order_(block_order), current_iterator_(NULL) { }
virtual ~FlowGraphVisitor() { }
+ ForwardInstructionIterator* current_iterator() const {
+ return current_iterator_;
+ }
+
// Visit each block in the block order, and for each block its
// instructions in order from the block entry to exit.
virtual void VisitBlocks();
@@ -2905,6 +2914,7 @@
protected:
const GrowableArray<BlockEntryInstr*>& block_order_;
+ ForwardInstructionIterator* current_iterator_;
private:
DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor);

Powered by Google App Engine
This is Rietveld 408576698